Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8588)

Issue 11533043: code review 11533043: runtime: handle morestack/lessstack in stack trace (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
11 months, 3 weeks ago
Reviewers:
shamsahmadms, dvyukov
CC:
golang-dev
Visibility:
Public.

Description

runtime: handle morestack/lessstack in stack trace If we start a garbage collection on g0 during a stack split or unsplit, we'll see morestack or lessstack at the top of the stack. Record an argument frame size for those, and record that they terminate the stack.

Patch Set 1 #

Patch Set 2 : diff -r 1203e3d32534 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1203e3d32534 https://code.google.com/p/go/ #

Total comments: 9

Patch Set 4 : diff -r dfd68fd535b8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r dfd68fd535b8 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -28 lines) Patch
M src/pkg/runtime/asm_386.s View 1 2 chunks +10 lines, -2 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 chunks +10 lines, -2 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 3 chunks +12 lines, -4 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 2 chunks +2 lines, -11 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M src/pkg/runtime/traceback_x86.c View 1 2 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 16
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 7 months ago (2013-07-18 17:18:12 UTC) #1
dvyukov
https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c#newcode181 src/pkg/runtime/proc.c:181: runtime·Gosched(); why is this?
10 years, 7 months ago (2013-07-18 20:15:13 UTC) #2
rsc
That was leftover debugging. I had the scavenger in a tight loop sleeping and stopping ...
10 years, 7 months ago (2013-07-18 20:17:00 UTC) #3
dvyukov
https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c#newcode2512 src/pkg/runtime/proc.c:2512: f->entry == (uintptr)runtime·morestack || if a goroutine calls e.g. ...
10 years, 7 months ago (2013-07-18 20:17:42 UTC) #4
dvyukov
On 2013/07/18 20:17:42, dvyukov wrote: > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c > File src/pkg/runtime/proc.c (right): > > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c#newcode2512 > ...
10 years, 7 months ago (2013-07-18 20:18:46 UTC) #5
rsc
https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c#newcode2512 src/pkg/runtime/proc.c:2512: f->entry == (uintptr)runtime·morestack || On 2013/07/18 20:17:42, dvyukov wrote: ...
10 years, 7 months ago (2013-07-18 20:24:29 UTC) #6
dvyukov
in traceback we have 2 options: 1. "should never happen", then we need to print/throw ...
10 years, 7 months ago (2013-07-18 20:32:16 UTC) #7
dvyukov
On 2013/07/18 20:24:29, rsc wrote: > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c > File src/pkg/runtime/proc.c (right): > > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/proc.c#newcode2512 > ...
10 years, 7 months ago (2013-07-18 20:34:26 UTC) #8
rsc
https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/traceback_x86.c File src/pkg/runtime/traceback_x86.c (right): https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/traceback_x86.c#newcode85 src/pkg/runtime/traceback_x86.c:85: runtime·printf("runtime: unknown pc %p after stack split\n", frame.pc); On ...
10 years, 7 months ago (2013-07-18 20:40:26 UTC) #9
dvyukov
On 2013/07/18 20:40:26, rsc wrote: > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/traceback_x86.c > File src/pkg/runtime/traceback_x86.c (right): > > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/traceback_x86.c#newcode85 > ...
10 years, 7 months ago (2013-07-18 20:45:51 UTC) #10
dvyukov
LGTM
10 years, 7 months ago (2013-07-18 20:45:59 UTC) #11
rsc
On 2013/07/18 20:45:51, dvyukov wrote: > On 2013/07/18 20:40:26, rsc wrote: > > > https://codereview.appspot.com/11533043/diff/6001/src/pkg/runtime/traceback_x86.c ...
10 years, 7 months ago (2013-07-18 20:46:20 UTC) #12
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=64b4f1c2e1d3 *** runtime: handle morestack/lessstack in stack trace If we start a ...
10 years, 7 months ago (2013-07-18 20:53:49 UTC) #13
dvyukov
On 2013/07/18 20:46:20, rsc wrote: > On 2013/07/18 20:45:51, dvyukov wrote: > > On 2013/07/18 ...
10 years, 7 months ago (2013-07-18 20:56:43 UTC) #14
rsc
The arg size lookup is disabled during cpu profiling now.
10 years, 7 months ago (2013-07-18 20:57:06 UTC) #15
shamsahmadms
11 months, 3 weeks ago (2023-03-09 10:45:37 UTC) #16
Message was sent while issue was closed.
Ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b