Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

Issue 11530043: Initial implementation of the Juju GUI server.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by frankban
Modified:
10 years, 4 months ago
Reviewers:
bac, hazmat, mp+175624, gary.poster
Visibility:
Public.

Description

Initial implementation of the Juju GUI server. This first cut of the server replaces the functionality provided in the charm by haproxy and apache. The server includes: - static files serving; - a WebSocket proxy handling the connections between the browser and the server and between the server and the Juju API; - HTTP to HTTPS redirecting. Further features like auth and deployer management will be added in the future. ws4py is used to implement the WebSocket client: there is something to fix there and it will be done in a future branch. At this time there is no easy way to QA the server, but tests can be run using `make unittest`: the test/lint suite is already integrated with the one used by the charm. Unfortunately the diff is quite long, sorry! https://code.launchpad.net/~frankban/charms/precise/juju-gui/server-base/+merge/175624 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 18

Patch Set 2 : Initial implementation of the Juju GUI server. #

Patch Set 3 : Initial implementation of the Juju GUI server. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+992 lines, -4 lines) Patch
M .bzrignore View 1 chunk +3 lines, -0 lines 0 comments Download
M Dependencies.md View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 2 chunks +3 lines, -1 line 0 comments Download
A Operation.md View 1 1 chunk +29 lines, -0 lines 0 comments Download
M README.md View 1 chunk +2 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 1 chunk +1 line, -1 line 0 comments Download
A server/guiserver/__init__.py View 1 1 chunk +38 lines, -0 lines 0 comments Download
A server/guiserver/apps.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
A server/guiserver/clients.py View 1 1 chunk +104 lines, -0 lines 0 comments Download
A server/guiserver/handlers.py View 1 chunk +87 lines, -0 lines 0 comments Download
A server/guiserver/manage.py View 1 chunk +81 lines, -0 lines 0 comments Download
A server/guiserver/tests/__init__.py View 1 chunk +21 lines, -0 lines 0 comments Download
A server/guiserver/tests/helpers.py View 1 chunk +66 lines, -0 lines 0 comments Download
A server/guiserver/tests/test_clients.py View 1 chunk +86 lines, -0 lines 0 comments Download
A server/guiserver/tests/test_handlers.py View 1 chunk +184 lines, -0 lines 0 comments Download
A server/guiserver/tests/test_manage.py View 1 chunk +91 lines, -0 lines 0 comments Download
A server/runserver.py View 1 chunk +29 lines, -0 lines 0 comments Download
A server/runtests.py View 1 chunk +36 lines, -0 lines 0 comments Download
A server/setup.py View 1 chunk +53 lines, -0 lines 0 comments Download
A tests/11-server.test View 1 chunk +19 lines, -0 lines 0 comments Download
M tests/requirements.pip View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
10 years, 8 months ago (2013-07-18 16:07:25 UTC) #1
gary.poster
Wow, code LGTM. I'll try to run tests now... https://codereview.appspot.com/11530043/diff/1/server/guiserver/apps.py File server/guiserver/apps.py (right): https://codereview.appspot.com/11530043/diff/1/server/guiserver/apps.py#newcode32 server/guiserver/apps.py:32: ...
10 years, 8 months ago (2013-07-18 21:07:31 UTC) #2
bac
LGTM: I echo Gary's 'wow' -- good work. I'll coordinate with Gary and see if ...
10 years, 8 months ago (2013-07-18 21:52:55 UTC) #3
frankban
Please take a look. https://codereview.appspot.com/11530043/diff/1/Operation.md File Operation.md (right): https://codereview.appspot.com/11530043/diff/1/Operation.md#newcode22 Operation.md:22: 443. HTTP connections to the ...
10 years, 8 months ago (2013-07-19 10:27:48 UTC) #4
frankban
Thank you both for the reviews!
10 years, 8 months ago (2013-07-19 10:35:21 UTC) #5
frankban
*** Submitted: Initial implementation of the Juju GUI server. This first cut of the server ...
10 years, 8 months ago (2013-07-19 14:20:48 UTC) #6
hazmat
10 years, 4 months ago (2013-11-06 08:43:28 UTC) #7
Just poking through the charm and came across this, its really nice work, well
done.

> R=gary.poster, bac
> CC=
> https://codereview.appspot.com/11530043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b