Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1520)

Issue 115300044: code review 115300044: liblink: support big-endian properly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by minux
Modified:
10 years, 7 months ago
Reviewers:
gobot, jsing, dave, rsc, adg, crawshaw
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

liblink: support big-endian properly

Patch Set 1 #

Patch Set 2 : diff -r fda4c0d14c53 https://code.google.com/p/go #

Patch Set 3 : diff -r fda4c0d14c53 https://code.google.com/p/go #

Patch Set 4 : diff -r fda4c0d14c53 https://code.google.com/p/go #

Patch Set 5 : diff -r b2131d729e52 https://code.google.com/p/go #

Patch Set 6 : diff -r b2131d729e52 https://code.google.com/p/go #

Patch Set 7 : diff -r 0015a2541545 https://code.google.com/p/go #

Patch Set 8 : diff -r b613f2acdf69 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M include/link.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/liblink/ld.c View 2 chunks +23 lines, -8 lines 0 comments Download
M src/liblink/obj5.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/liblink/obj6.c View 2 chunks +2 lines, -0 lines 0 comments Download
M src/liblink/obj8.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/liblink/sym.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
minux
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-08-06 03:27:51 UTC) #1
rsc
LGTM
10 years, 7 months ago (2014-08-06 03:34:46 UTC) #2
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=197d48d17522 *** liblink: support big-endian properly LGTM=rsc R=rsc, iant CC=golang-codereviews https://codereview.appspot.com/115300044
10 years, 7 months ago (2014-08-06 04:25:44 UTC) #3
gobot
This CL appears to have broken the openbsd-386-rootbsd builder. See http://build.golang.org/log/c6ae7f882b9fe723fc80beffd623269645be6930
10 years, 7 months ago (2014-08-06 10:45:13 UTC) #4
dave_cheney.net
Is there any change which does not break the openbsd-386-rootbsd builder? On 6 Aug 2014 ...
10 years, 7 months ago (2014-08-06 10:55:54 UTC) #5
minux
On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote: > Is there ...
10 years, 7 months ago (2014-08-06 17:52:11 UTC) #6
crawshaw
I have a fresh openbsd/386 vm running if anyone with google corp network access wants ...
10 years, 7 months ago (2014-08-06 19:11:54 UTC) #7
adg
+jsing, who runs the openbsd-*-rootbsd builders. I see an openbsd-386-crawshaw has started... On 7 August ...
10 years, 7 months ago (2014-08-07 00:31:50 UTC) #8
jsing
The openbsd-386-rootbsd builder had a number of runaway Python hg processes, which were causing it ...
10 years, 7 months ago (2014-08-07 01:12:16 UTC) #9
crawshaw
10 years, 7 months ago (2014-08-07 14:11:21 UTC) #10
I'm happy to not to run a builder if you have the *-rootbsd machines
under control. Thanks!

On Wed, Aug 6, 2014 at 9:12 PM, Joel Sing <jsing@google.com> wrote:
> The openbsd-386-rootbsd builder had a number of runaway Python hg processes,
> which were causing it to run slowly. I killed all of these yesterday (or the
> day before) and it appears to have been running fine again over the last 24+
> hours. FTR the "hardware" is the same for both the openbsd-386-rootbsd and
> openbsd-amd64-builders, plus we've not seen issues in the past.
>
> Unfortunately, I've not been watching golang-dev/golang-codereviews closely
> over the last month or so - if it happens again please feel free to ping me
> if it is not fixed quickly.
>
>
> On 7 August 2014 10:31, Andrew Gerrand <adg@golang.org> wrote:
>>
>> +jsing, who runs the openbsd-*-rootbsd builders.
>>
>> I see an openbsd-386-crawshaw has started...
>>
>>
>> On 7 August 2014 05:11, David Crawshaw <crawshaw@golang.org> wrote:
>>>
>>> I have a fresh openbsd/386 vm running if anyone with google corp
>>> network access wants to get a builder going on it.
>>>
>>> On Wed, Aug 6, 2014 at 1:51 PM, minux <minux@golang.org> wrote:
>>> >
>>> > On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:
>>> >>
>>> >> Is there any change which does not break the openbsd-386-rootbsd
>>> >> builder?
>>> >
>>> > Good question. I think this particular builder to be very flaky
>>> > recently.
>>> > Seems the builder is just slow? the cmd/pack test does need a long time
>>> > to
>>> > finish.
>>> >
>>> > Andrew, could we find a faster openbsd/386 builder?
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> > Groups
>>> > "golang-codereviews" group.
>>> > To unsubscribe from this group and stop receiving emails from it, send
>>> > an
>>> > email to golang-codereviews+unsubscribe@googlegroups.com.
>>> > For more options, visit https://groups.google.com/d/optout.
>>
>>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b