code review 115300044: liblink: support big-endian properly

liblink: support big-endian properly

[minux, 2014-08-06 03:27:51]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-08-06 03:34:46]

LGTM

[minux, 2014-08-06 04:25:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=197d48d17522 ***

liblink: support big-endian properly

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/115300044

[gobot, 2014-08-06 10:45:13]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/c6ae7f882b9fe723fc80beffd623269645be6930

[dave_cheney.net, 2014-08-06 10:55:54]

Is there any change which does not break the openbsd-386-rootbsd builder?
On 6 Aug 2014 20:45, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-386-rootbsd builder.
> See http://build.golang.org/log/c6ae7f882b9fe723fc80beffd623269645be6930
>
> https://codereview.appspot.com/115300044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux, 2014-08-06 17:52:11]

On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:

> Is there any change which does not break the openbsd-386-rootbsd builder?
>
Good question. I think this particular builder to be very flaky recently.
Seems the builder is just slow? the cmd/pack test does need a long time to
finish.

Andrew, could we find a faster openbsd/386 builder?

[crawshaw, 2014-08-06 19:11:54]

I have a fresh openbsd/386 vm running if anyone with google corp
network access wants to get a builder going on it.

On Wed, Aug 6, 2014 at 1:51 PM, minux <minux@golang.org> wrote:
>
> On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:
>>
>> Is there any change which does not break the openbsd-386-rootbsd builder?
>
> Good question. I think this particular builder to be very flaky recently.
> Seems the builder is just slow? the cmd/pack test does need a long time to
> finish.
>
> Andrew, could we find a faster openbsd/386 builder?
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[adg, 2014-08-07 00:31:50]

+jsing, who runs the openbsd-*-rootbsd builders.

I see an openbsd-386-crawshaw has started...


On 7 August 2014 05:11, David Crawshaw <crawshaw@golang.org> wrote:

> I have a fresh openbsd/386 vm running if anyone with google corp
> network access wants to get a builder going on it.
>
> On Wed, Aug 6, 2014 at 1:51 PM, minux <minux@golang.org> wrote:
> >
> > On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:
> >>
> >> Is there any change which does not break the openbsd-386-rootbsd
> builder?
> >
> > Good question. I think this particular builder to be very flaky recently.
> > Seems the builder is just slow? the cmd/pack test does need a long time
> to
> > finish.
> >
> > Andrew, could we find a faster openbsd/386 builder?
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>

[jsing, 2014-08-07 01:12:16]

The openbsd-386-rootbsd builder had a number of runaway Python hg
processes, which were causing it to run slowly. I killed all of these
yesterday (or the day before) and it appears to have been running fine
again over the last 24+ hours. FTR the "hardware" is the same for both the
openbsd-386-rootbsd and openbsd-amd64-builders, plus we've not seen issues
in the past.

Unfortunately, I've not been watching golang-dev/golang-codereviews closely
over the last month or so - if it happens again please feel free to ping me
if it is not fixed quickly.


On 7 August 2014 10:31, Andrew Gerrand <adg@golang.org> wrote:

> +jsing, who runs the openbsd-*-rootbsd builders.
>
> I see an openbsd-386-crawshaw has started...
>
>
> On 7 August 2014 05:11, David Crawshaw <crawshaw@golang.org> wrote:
>
>> I have a fresh openbsd/386 vm running if anyone with google corp
>> network access wants to get a builder going on it.
>>
>> On Wed, Aug 6, 2014 at 1:51 PM, minux <minux@golang.org> wrote:
>> >
>> > On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:
>> >>
>> >> Is there any change which does not break the openbsd-386-rootbsd
>> builder?
>> >
>> > Good question. I think this particular builder to be very flaky
>> recently.
>> > Seems the builder is just slow? the cmd/pack test does need a long time
>> to
>> > finish.
>> >
>> > Andrew, could we find a faster openbsd/386 builder?
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups
>> > "golang-codereviews" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> > email to golang-codereviews+unsubscribe@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>
>

[crawshaw, 2014-08-07 14:11:21]

I'm happy to not to run a builder if you have the *-rootbsd machines
under control. Thanks!

On Wed, Aug 6, 2014 at 9:12 PM, Joel Sing <jsing@google.com> wrote:
> The openbsd-386-rootbsd builder had a number of runaway Python hg processes,
> which were causing it to run slowly. I killed all of these yesterday (or the
> day before) and it appears to have been running fine again over the last 24+
> hours. FTR the "hardware" is the same for both the openbsd-386-rootbsd and
> openbsd-amd64-builders, plus we've not seen issues in the past.
>
> Unfortunately, I've not been watching golang-dev/golang-codereviews closely
> over the last month or so - if it happens again please feel free to ping me
> if it is not fixed quickly.
>
>
> On 7 August 2014 10:31, Andrew Gerrand <adg@golang.org> wrote:
>>
>> +jsing, who runs the openbsd-*-rootbsd builders.
>>
>> I see an openbsd-386-crawshaw has started...
>>
>>
>> On 7 August 2014 05:11, David Crawshaw <crawshaw@golang.org> wrote:
>>>
>>> I have a fresh openbsd/386 vm running if anyone with google corp
>>> network access wants to get a builder going on it.
>>>
>>> On Wed, Aug 6, 2014 at 1:51 PM, minux <minux@golang.org> wrote:
>>> >
>>> > On Wed, Aug 6, 2014 at 6:55 AM, Dave Cheney <dave@cheney.net> wrote:
>>> >>
>>> >> Is there any change which does not break the openbsd-386-rootbsd
>>> >> builder?
>>> >
>>> > Good question. I think this particular builder to be very flaky
>>> > recently.
>>> > Seems the builder is just slow? the cmd/pack test does need a long time
>>> > to
>>> > finish.
>>> >
>>> > Andrew, could we find a faster openbsd/386 builder?
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> > Groups
>>> > "golang-codereviews" group.
>>> > To unsubscribe from this group and stop receiving emails from it, send
>>> > an
>>> > email to golang-codereviews+unsubscribe@googlegroups.com.
>>> > For more options, visit https://groups.google.com/d/optout.
>>
>>
>