Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(875)

Issue 115280043: code review 115280043: runtime: generate type info for chans (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by dvyukov
Modified:
6 years, 4 months ago
Reviewers:
khr1
CC:
golang-codereviews, khr1, khr
Visibility:
Public.

Description

runtime: generate type info for chans

Patch Set 1 #

Patch Set 2 : diff -r b6a42b0aeef6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b6a42b0aeef6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r b6a42b0aeef6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 6125ea2b1dbf https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r f8c861d4047a https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M src/pkg/runtime/chan.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/pkg/runtime/chan.goc View 2 chunks +38 lines, -5 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
6 years, 4 months ago (2014-07-29 11:51:43 UTC) #1
khr1
LGTM. On Tue, Jul 29, 2014 at 4:51 AM, <dvyukov@google.com> wrote: > Reviewers: golang-codereviews, > ...
6 years, 4 months ago (2014-07-29 16:48:28 UTC) #2
dvyukov
6 years, 4 months ago (2014-07-29 18:06:55 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=6ced5a748d5e ***

runtime: generate type info for chans

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, khr
https://codereview.appspot.com/115280043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b