Issue 11526043: Landing ants latest inspector style branch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11526043: Landing ants latest inspector style branch

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+175610

Visibility:
Public.

Description

Landing ants latest inspector style branch https://code.launchpad.net/~hatch/juju-gui/ant-inspector-unit-styles/+merge/175610 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing ants latest inspector style branch #

Patch Set 3 : Landing ants latest inspector style branch #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -18 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/serviceOverview.handlebars	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/views/juju-inspector.less	View	1	3 chunks	+113 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM once the story with that div is clear, I think we can remove it ...

10 years, 9 months ago (2013-07-18 15:48:47 UTC) #2

jeff.pihach

10 years, 9 months ago (2013-07-18 16:15:22 UTC) #4

*** Submitted:

Landing ants latest inspector style branch

R=benjamin.saller
CC=
https://codereview.appspot.com/11526043

Expand All Messages | Collapse All Messages