Issue 11525044: Unit list overview fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11525044: Unit list overview fixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
mp+175672, matthew.scott

Visibility:
Public.

Description

Unit list overview fixes User friendly header labels Sorting headers Fixed height calculation bug https://code.launchpad.net/~hatch/juju-gui/fix-units-height/+merge/175672 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Unit list overview fixes #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -25 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/service.js	View		6 chunks	+29 lines, -6 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/test_inspector_overview.js	View	1	4 chunks	+20 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

matthew.scott

LGTM, line numbers are from MP 122: Caps, period at the end

10 years, 9 months ago (2013-07-18 20:24:32 UTC) #2

jeff.pihach

10 years, 9 months ago (2013-07-18 20:31:21 UTC) #3

*** Submitted:

Unit list overview fixes

User friendly header labels
Sorting headers
Fixed height calculation bug

R=matthew.scott
CC=
https://codereview.appspot.com/11525044

Expand All Messages | Collapse All Messages