Azure provider: create virtual network.

Azure provider: create virtual network.

Each azure environment must be associated with an affinity group and a virtual network used for direct machine-to-machine communication. This branch adds all the utilities to create and delete the environment's affinity group and virtual network.  The Bootstrap() method is still being refactored and is thus left untested for now.  Branches to remove the environment's affinity group and virtual network (when the environment is destroyed) and use the private address for machine-to-machine communication will follow.

https://code.launchpad.net/~rvb/juju-core/create-vnet/+merge/175315

(do not edit description out of merge proposal)

[rvb, 2013-07-19 07:04:42]

Please take a look.

[dimitern, 2013-07-19 08:17:04]

LGTM with a couple of suggestions.

https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:173: func (env *azureEnviron) destroyAffinityGroup()
error {
Why not deleteAffinityGroup?

https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:208: func (env *azureEnviron) destroyVirtualNetwork()
error {
removeVirtualNetwork ? (for consistency with the gwacl API) Or
deleteVirtualNetwork perhaps? (for consistency with the provider API)

[rvb, 2013-07-19 08:24:15]

On 2013/07/19 08:17:04, dimitern wrote:
> LGTM with a couple of suggestions.
> 
> https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go
> File environs/azure/environ.go (right):
> 
>
https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:173: func (env *azureEnviron) destroyAffinityGroup()
> error {
> Why not deleteAffinityGroup?
> 
>
https://codereview.appspot.com/11524044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:208: func (env *azureEnviron)
destroyVirtualNetwork()
> error {
> removeVirtualNetwork ? (for consistency with the gwacl API) Or
> deleteVirtualNetwork perhaps? (for consistency with the provider API)

Good points, I've renamed the methods.