Issue 11521043: Inspector units contains landscape annotations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11521043: Inspector units contains landscape annotations

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+175597, gary.poster

Visibility:
Public.

Description

Inspector units contains landscape annotations The new service inspector unit list now shows units which require a landscape security update or require a reboot in their own section. https://code.launchpad.net/~hatch/juju-gui/landscape-unit/+merge/175597 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Inspector units contains landscape annotations #

Patch Set 3 : Inspector units contains landscape annotations #

Patch Set 4 : Inspector units contains landscape annotations #

Patch Set 5 : Inspector units contains landscape annotations #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -7 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/service.js	View	1 2 3	2 chunks	+16 lines, -4 lines	0 comments	Download
M	app/views/utils.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	bin/merge-files	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/test_inspector_overview.js	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	test/test_utils.js	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, thanks https://codereview.appspot.com/11521043/diff/1/app/views/service.js File app/views/service.js (right): https://codereview.appspot.com/11521043/diff/1/app/views/service.js#newcode1615 app/views/service.js:1615: unitByStatus[annotation].push(value); It might not be clear during ...

10 years, 9 months ago (2013-07-18 15:33:17 UTC) #2

gary.poster

LGTM with trivial https://codereview.appspot.com/11521043/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/11521043/diff/1/app/views/utils.js#newcode1131 app/views/utils.js:1131: Returns an array of user friendly ...

10 years, 9 months ago (2013-07-18 16:22:23 UTC) #3

jeff.pihach

10 years, 9 months ago (2013-07-18 18:21:02 UTC) #4

*** Submitted:

Inspector units contains landscape annotations

The new service inspector unit list now shows 
units which require a landscape security update
or require a reboot in their own section.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/11521043

Expand All Messages | Collapse All Messages