Issue 115100043: code review 115100043: g: search in *.s files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115100043: code review 115100043: g: search in *.s files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by aram

Modified:
9 years, 8 months ago

Reviewers:
rsc

CC:
rsc, plan9port-dev_googlegroups.com

Visibility:
Public.

Description

g: search in *.s files

Patch Set 1 #

Patch Set 2 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 3 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 4 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 5 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 6 : diff -r 06ddd98c468a https://code.google.com/p/plan9port #

Patch Set 7 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port #

Patch Set 8 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/g	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

aram

Hello rsc, I'd like you to review this change to https://bitbucket.org/rsc/plan9port

9 years, 9 months ago (2014-07-19 15:27:13 UTC) #1

aram

Hello rsc@golang.org (cc: plan9port-dev@googlegroups.com), Please take another look.

9 years, 9 months ago (2014-07-19 15:31:42 UTC) #2

rsc

LGTM but single letters go in the character class please reconfigure your client to use ...

9 years, 8 months ago (2014-08-05 18:23:30 UTC) #3

aram

Hello rsc@golang.org (cc: plan9port-dev@googlegroups.com), Please take another look.

9 years, 8 months ago (2014-08-06 11:45:59 UTC) #4

aram

9 years, 8 months ago (2014-08-06 12:36:51 UTC) #6

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=f5d3dc0fbcc0 ***

g: search in *.s files

LGTM=rsc
R=rsc
CC=plan9port-dev
https://codereview.appspot.com/115100043

Expand All Messages | Collapse All Messages