Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 115100043: code review 115100043: g: search in *.s files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by aram
Modified:
10 years, 4 months ago
Reviewers:
rsc
CC:
rsc, plan9port-dev_googlegroups.com
Visibility:
Public.

Description

g: search in *.s files

Patch Set 1 #

Patch Set 2 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 3 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 4 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 5 : diff -r 06ddd98c468a https://bitbucket.org/rsc/plan9port #

Patch Set 6 : diff -r 06ddd98c468a https://code.google.com/p/plan9port #

Patch Set 7 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port #

Patch Set 8 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bin/g View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
aram
Hello rsc, I'd like you to review this change to https://bitbucket.org/rsc/plan9port
10 years, 5 months ago (2014-07-19 15:27:13 UTC) #1
aram
Hello rsc@golang.org (cc: plan9port-dev@googlegroups.com), Please take another look.
10 years, 5 months ago (2014-07-19 15:31:42 UTC) #2
rsc
LGTM but single letters go in the character class please reconfigure your client to use ...
10 years, 4 months ago (2014-08-05 18:23:30 UTC) #3
aram
Hello rsc@golang.org (cc: plan9port-dev@googlegroups.com), Please take another look.
10 years, 4 months ago (2014-08-06 11:45:59 UTC) #4
rsc
LGTM you should be able to hg submit
10 years, 4 months ago (2014-08-06 12:33:06 UTC) #5
aram
10 years, 4 months ago (2014-08-06 12:36:51 UTC) #6
*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=f5d3dc0fbcc0 ***

g: search in *.s files

LGTM=rsc
R=rsc
CC=plan9port-dev
https://codereview.appspot.com/115100043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b