Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 115060044: code review 115060044: liblink, cmd/dist, cmd/5l: introduce %^ and move C_* co... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by minux
Modified:
10 years, 9 months ago
Reviewers:
gobot, rsc, dave, 0intro
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

liblink, cmd/dist, cmd/5l: introduce %^ and move C_* constants. The helps certain diagnostics and also removed duplicated enums as a side effect.

Patch Set 1 #

Patch Set 2 : diff -r 26ba1fd4913d https://code.google.com/p/go #

Patch Set 3 : diff -r 26ba1fd4913d https://code.google.com/p/go #

Patch Set 4 : diff -r 6f0ff681e5ea https://code.google.com/p/go #

Patch Set 5 : diff -r 921b20438940 https://code.google.com/p/go #

Patch Set 6 : diff -r 921b20438940 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -97 lines) Patch
M include/link.h View 4 chunks +5 lines, -2 lines 0 comments Download
M src/cmd/5l/5.out.h View 1 chunk +51 lines, -0 lines 0 comments Download
M src/cmd/5l/l.h View 1 chunk +0 lines, -46 lines 0 comments Download
M src/cmd/dist/buildgc.c View 2 chunks +21 lines, -1 line 0 comments Download
M src/liblink/asm5.c View 3 chunks +2 lines, -48 lines 0 comments Download
M src/liblink/list5.c View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7
minux
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2014-07-19 02:17:36 UTC) #1
dave_cheney.net
LGTM. Testing on linux/arm
10 years, 9 months ago (2014-07-21 10:07:08 UTC) #2
rsc
LGTM
10 years, 9 months ago (2014-08-05 18:21:41 UTC) #3
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=13057b322411 *** liblink, cmd/dist, cmd/5l: introduce %^ and move C_* constants. The ...
10 years, 9 months ago (2014-08-06 04:31:26 UTC) #4
0intro
It seems this change broke the Plan 9 build. -- David du Colombier
10 years, 9 months ago (2014-08-06 07:03:06 UTC) #5
gobot
This CL appears to have broken the plan9-386-cnielsen builder. See http://build.golang.org/log/bd3b29fd728960901634879d052406b5cefa7d32
10 years, 9 months ago (2014-08-06 07:09:11 UTC) #6
0intro
10 years, 9 months ago (2014-08-06 08:37:31 UTC) #7
It happens because mkanames now declares an empty array in
anames8.c and anames6.c, which is not valid for the Plan 9 compiler.

char* cnames8[] = {
};

-- 
David du Colombier
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b