Issue 11493043: Rename --force-machine to --to

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11493043: Rename --force-machine to --to (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by wallyworld

Modified:
10 years, 1 month ago

Reviewers:
mp+175436, dimitern, thumper

Visibility:
Public.

Description

Rename --force-machine to --to The --force-machine argument used with deploy and add-unit it renamed to --to. Some examples are added to the command docs. https://code.launchpad.net/~wallyworld/juju-core/rename-force-machine/+merge/175436 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -91 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/addunit.go	View	4 chunks	+24 lines, -13 lines	2 comments	Download
M	cmd/juju/addunit_test.go	View	5 chunks	+11 lines, -11 lines	0 comments	Download
M	cmd/juju/deploy.go	View	4 chunks	+14 lines, -9 lines	0 comments	Download
M	cmd/juju/deploy_test.go	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn.go	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	juju/conn_test.go	View	3 chunks	+15 lines, -15 lines	0 comments	Download
M	state/api/params/params.go	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	state/apiserver/client/client.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/statecmd/addunit.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/statecmd/addunit_test.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

LGTM - hoping you look at the help wording. https://codereview.appspot.com/11493043/diff/1/cmd/juju/addunit.go File cmd/juju/addunit.go (right): https://codereview.appspot.com/11493043/diff/1/cmd/juju/addunit.go#newcode26 cmd/juju/addunit.go:26: ...

10 years, 9 months ago (2013-07-18 02:46:06 UTC) #2

LGTM

Expand All Messages | Collapse All Messages