Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(647)

Issue 11492044: Azure provider: support most recent gwacl

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rvb
Modified:
10 years, 8 months ago
Reviewers:
mp+176211, allenap, rog
Visibility:
Public.

Description

Azure provider: support most recent gwacl This branch updates the Azure provider code to cope with the latest version of gwacl. Two changes in gwacl require the provider code to be updated: - 'UserData' has been renamed 'CustomData' in the linux configuration object. - gwacl no longer uses go-curl but instead uses a forked crypto/tls package which supports TLS renegociation. This requires a couple of changes in the tests because the crypto/tls package requires a valid certificate. https://code.launchpad.net/~rvb/juju-core/latest-gwacl/+merge/176211 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Azure provider: support most recent gwacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/azure/config_test.go View 1 chunk +20 lines, -1 line 0 comments Download
M environs/azure/environ_test.go View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4
rvb
Please take a look.
10 years, 8 months ago (2013-07-22 14:36:28 UTC) #1
allenap
LGTM
10 years, 8 months ago (2013-07-22 14:40:55 UTC) #2
rvb
Please take a look.
10 years, 8 months ago (2013-07-22 14:42:07 UTC) #3
rog
10 years, 8 months ago (2013-07-22 15:26:59 UTC) #4
On 2013/07/22 14:42:07, rvb wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b