Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(992)

Issue 11491043: Add the autostart symlink for containers.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by thumper
Modified:
10 years, 9 months ago
Reviewers:
dave, mp+175435, wallyworld
Visibility:
Public.

Description

Add the autostart symlink for containers. In order for containers to autostart, there needs to be a symlink in /etc/lxc/auto called CN.conf where CN is the container name, which points to the config file for the container, which is by default /var/lib/lxc/CN/config. https://code.launchpad.net/~thumper/juju-core/auto-restart-containers/+merge/175435 Requires: https://code.launchpad.net/~thumper/juju-core/test-import-fix/+merge/175430 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M container/lxc/lxc.go View 3 chunks +15 lines, -0 lines 1 comment Download
M container/lxc/lxc_test.go View 4 chunks +14 lines, -0 lines 0 comments Download
M container/lxc/test.go View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
10 years, 9 months ago (2013-07-18 00:57:50 UTC) #1
wallyworld
LGTM https://codereview.appspot.com/11491043/diff/1/container/lxc/lxc.go File container/lxc/lxc.go (right): https://codereview.appspot.com/11491043/diff/1/container/lxc/lxc.go#newcode131 container/lxc/lxc.go:131: linkLocation := filepath.Join(lxcRestartDir, name+".conf") perhaps make name+".conf" a ...
10 years, 9 months ago (2013-07-18 02:01:56 UTC) #2
dave_cheney.net
10 years, 9 months ago (2013-07-18 02:44:07 UTC) #3
On 2013/07/18 02:01:56, wallyworld wrote:
> LGTM
> 
> https://codereview.appspot.com/11491043/diff/1/container/lxc/lxc.go
> File container/lxc/lxc.go (right):
> 
> https://codereview.appspot.com/11491043/diff/1/container/lxc/lxc.go#newcode131
> container/lxc/lxc.go:131: linkLocation := filepath.Join(lxcRestartDir,
> name+".conf")
> perhaps make name+".conf" a function as it's used twice

LGTM. Extra points if you want to add the helper wallyworld suggested.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b