Issue 11474043: Implements view container left slot wrapper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11474043: Implements view container left slot wrapper

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
mp+175393, matthew.scott, gary.poster

Visibility:
Public.

Description

Implements view container left slot wrapper Along with the left slot wrapper it also includes a method to hide the current slot via the included close button https://code.launchpad.net/~hatch/juju-gui/unit-left-wrapper/+merge/175393 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Implements view container left slot wrapper #

Total comments: 1

Patch Set 3 : Implements view container left slot wrapper #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -28 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/config-prod.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	app/templates/left-breakout-panel.handlebars	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/templates/view-container.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/environment.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	app/views/service.js	View		6 chunks	+21 lines, -15 lines	0 comments	Download
M	app/views/view-container.js	View	1 2	3 chunks	+25 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		3 chunks	+17 lines, -1 line	0 comments	Download
M	test/test_view_container.js	View		5 chunks	+40 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

LGTM Thank you! https://codereview.appspot.com/11474043/diff/3002/app/views/view-container.js File app/views/view-container.js (right): https://codereview.appspot.com/11474043/diff/3002/app/views/view-container.js#newcode385 app/views/view-container.js:385: Event callback which hides the viewlet ...

10 years, 9 months ago (2013-07-17 22:27:52 UTC) #4

jeff.pihach

10 years, 9 months ago (2013-07-18 00:35:00 UTC) #5

*** Submitted:

Implements view container left slot wrapper

Along with the left slot wrapper it also includes
a method to hide the current slot via the included
close button

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/11474043

Expand All Messages | Collapse All Messages