Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 11469043: Reverts r 852

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by j.c.sackett
Modified:
7 years, 3 months ago
Reviewers:
bac, mp+175382, gary.poster
Visibility:
Public.

Description

Reverts r 852 r 852 introduced Ant's CSS changes, which caused an error in the charm panel. This reverts those changes. https://code.launchpad.net/~jcsackett/juju-gui/revert-852/+merge/175382 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Reverts r 852 #

Patch Set 3 : Reverts r 852 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -83 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/images/inspector-close-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/inspector-destroy-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/templates/charm-pre-configuration.handlebars View 1 chunk +0 lines, -1 line 0 comments Download
M lib/views/juju-inspector.less View 2 chunks +18 lines, -83 lines 0 comments Download
M lib/views/stylesheet.less View 1 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5
j.c.sackett
Please take a look.
7 years, 3 months ago (2013-07-17 19:31:53 UTC) #1
gary.poster
LGTM thank you
7 years, 3 months ago (2013-07-17 19:34:29 UTC) #2
bac
LGTM
7 years, 3 months ago (2013-07-17 19:36:44 UTC) #3
bac
LGTM (may have published earlier)
7 years, 3 months ago (2013-07-17 19:38:00 UTC) #4
j.c.sackett
7 years, 3 months ago (2013-07-17 19:56:06 UTC) #5
*** Submitted:

Reverts r 852

r 852 introduced Ant's CSS changes, which caused an error in the charm panel.
This reverts those changes.

R=gary.poster, bac
CC=
https://codereview.appspot.com/11469043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b