Issue 11469043: Reverts r 852

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11469043: Reverts r 852

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by j.c.sackett

Modified:
10 years, 9 months ago

Reviewers:
bac, mp+175382, gary.poster

Visibility:
Public.

Description

Reverts r 852 r 852 introduced Ant's CSS changes, which caused an error in the charm panel. This reverts those changes. https://code.launchpad.net/~jcsackett/juju-gui/revert-852/+merge/175382 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Reverts r 852 #

Patch Set 3 : Reverts r 852 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -83 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
D	app/assets/images/inspector-close-icon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	app/assets/images/inspector-destroy-icon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/templates/charm-pre-configuration.handlebars	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/views/juju-inspector.less	View		2 chunks	+18 lines, -83 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1	4 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

j.c.sackett

10 years, 9 months ago (2013-07-17 19:56:06 UTC) #5

*** Submitted:

Reverts r 852

r 852 introduced Ant's CSS changes, which caused an error in the charm panel.
This reverts those changes.

R=gary.poster, bac
CC=
https://codereview.appspot.com/11469043

Expand All Messages | Collapse All Messages