Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 11465044: Bug with viewlets being appended in inspector

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by matthew.scott
Modified:
7 years, 3 months ago
Reviewers:
mp+175379, benjamin.saller, jeff.pihach
Visibility:
Public.

Description

Bug with viewlets being appended in inspector Viewlets in default slot are not being hidden due to a previous branch. This hides viewlets without a 'slot' attribute. https://code.launchpad.net/~makyo/juju-gui/oh-noooo/+merge/175379 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Bug with viewlets being appended in inspector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/view-container.js View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
7 years, 3 months ago (2013-07-17 19:18:44 UTC) #1
benjamin.saller
LGTM, thanks
7 years, 3 months ago (2013-07-17 19:37:23 UTC) #2
jeff.pihach
LGTM Thanks for the fix!
7 years, 3 months ago (2013-07-17 19:38:39 UTC) #3
matthew.scott
7 years, 3 months ago (2013-07-17 19:46:10 UTC) #4
*** Submitted:

Bug with viewlets being appended in inspector

Viewlets in default slot are not being hidden due to a previous branch.  This
hides viewlets without a 'slot' attribute.

R=benjamin.saller, jeff.pihach
CC=
https://codereview.appspot.com/11465044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b