Issue 11463044: state/api/machiner: Cleanup tests and code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11463044: state/api/machiner: Cleanup tests and code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dimitern

Modified:
10 years, 9 months ago

Reviewers:
gz, mp+176180, rog

Visibility:
Public.

Description

state/api/machiner: Cleanup tests and code This is a trivial change in the machiner API facade's implementation and test suite to make them closer to the other facades. Next in line is replacing state calls with API calls in the machiner worker. https://code.launchpad.net/~dimitern/juju-core/trunk/+merge/176180 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -78 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/machiner/machine.go	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	state/api/machiner/machiner.go	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	state/api/machiner/machiner_test.go	View	3 chunks	+72 lines, -63 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages