Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(801)

Issue 11463044: state/api/machiner: Cleanup tests and code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by dimitern
Modified:
6 years, 3 months ago
Reviewers:
gz, mp+176180, rog
Visibility:
Public.

Description

state/api/machiner: Cleanup tests and code This is a trivial change in the machiner API facade's implementation and test suite to make them closer to the other facades. Next in line is replacing state calls with API calls in the machiner worker. https://code.launchpad.net/~dimitern/juju-core/trunk/+merge/176180 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -78 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/machiner/machine.go View 6 chunks +8 lines, -8 lines 0 comments Download
M state/api/machiner/machiner.go View 2 chunks +7 lines, -7 lines 0 comments Download
M state/api/machiner/machiner_test.go View 3 chunks +72 lines, -63 lines 0 comments Download

Messages

Total messages: 3
dimitern
Please take a look.
6 years, 3 months ago (2013-07-22 12:22:17 UTC) #1
rog
LGTM, thanks.
6 years, 3 months ago (2013-07-22 12:49:57 UTC) #2
gz
6 years, 3 months ago (2013-07-22 13:57:57 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b