Azure provider: add state file URL

Azure provider: add state file URL

Ian's last branch requires the machine configuration to contain a string with the URL of the state file.  This branch adds that in startBootstrapInstance() in the Azure provider.  No unit test for this yet because that area is still being refactored but I've tested this change manually and was able to bootstrap a node on Azure and deploy a couple of nodes.  Drive-by fix: add missing return statement in cmd/jujud/bootstrap.go.

https://code.launchpad.net/~rvb/juju-core/fix-az-prov/+merge/175574

(do not edit description out of merge proposal)

[rvb, 2013-07-18 14:13:05]

Please take a look.

[rog, 2013-07-18 14:17:28]

LGTM with trivial adjustments below

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
%q, %v", stateInfoURL, providerStateURLFile, err)
"cannot load state from %q (read from %q): %v" ?

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:139: // Create an empty bootstrap state file so we can
get it's URL.
s/it's/its/

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:142: reader := strings.NewReader("")
or inline

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
reader, int64(0))
s/int64(0)/0/
(no need for the explicit type)

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
state file: %v", err)
"cannot get URL for bootstrap state file: %v"

[rvb, 2013-07-18 14:23:16]

On 2013/07/18 14:17:28, rog wrote:
> LGTM with trivial adjustments below
> 
> https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
> File cmd/jujud/bootstrap.go (right):
> 
>
https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
> cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
> %q, %v", stateInfoURL, providerStateURLFile, err)
> "cannot load state from %q (read from %q): %v" ?
> 
> https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
> File environs/azure/environ.go (right):
> 
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:139: // Create an empty bootstrap state file so we
can
> get it's URL.
> s/it's/its/
> 
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:142: reader := strings.NewReader("")
> or inline
> 
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
> reader, int64(0))
> s/int64(0)/0/
> (no need for the explicit type)
> 
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
> state file: %v", err)
> "cannot get URL for bootstrap state file: %v"

All done, thanks for the review!

[rog, 2013-07-18 14:26:58]

On 2013/07/18 14:23:16, rvb wrote:
> On 2013/07/18 14:17:28, rog wrote:
> > LGTM with trivial adjustments below
> > 
> > https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
> > File cmd/jujud/bootstrap.go (right):
> > 
> >
>
https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
> > cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL
%q:
> > %q, %v", stateInfoURL, providerStateURLFile, err)
> > "cannot load state from %q (read from %q): %v" ?
> > 
> > https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
> > File environs/azure/environ.go (right):
> > 
> >
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> > environs/azure/environ.go:139: // Create an empty bootstrap state file so we
> can
> > get it's URL.
> > s/it's/its/
> > 
> >
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> > environs/azure/environ.go:142: reader := strings.NewReader("")
> > or inline
> > 
> >
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> > environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
> > reader, int64(0))
> > s/int64(0)/0/
> > (no need for the explicit type)
> > 
> >
>
https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
> > environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create
bootstrap
> > state file: %v", err)
> > "cannot get URL for bootstrap state file: %v"
> 
> All done, thanks for the review!

i don't see the changes yet...

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
%q, %v", stateInfoURL, providerStateURLFile, err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot load state from %q (read from %q): %v" ?

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
reader, int64(0))
On 2013/07/18 14:17:28, rog wrote:
> s/int64(0)/0/
> (no need for the explicit type)

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
state file: %v", err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot get URL for bootstrap state file: %v"

+1

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
%q, %v", stateInfoURL, providerStateURLFile, err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot load state from %q (read from %q): %v" ?

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
reader, int64(0))
On 2013/07/18 14:17:28, rog wrote:
> s/int64(0)/0/
> (no need for the explicit type)

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
state file: %v", err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot get URL for bootstrap state file: %v"

+1

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
%q, %v", stateInfoURL, providerStateURLFile, err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot load state from %q (read from %q): %v" ?

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
reader, int64(0))
On 2013/07/18 14:17:28, rog wrote:
> s/int64(0)/0/
> (no need for the explicit type)

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
state file: %v", err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot get URL for bootstrap state file: %v"

+1

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/11462044/diff/1/cmd/jujud/bootstrap.go#newcode101
cmd/jujud/bootstrap.go:101: return fmt.Errorf("cannot load state from URL %q:
%q, %v", stateInfoURL, providerStateURLFile, err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot load state from %q (read from %q): %v" ?

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go
File environs/azure/environ.go (right):

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:143: err := env.Storage().Put(environs.StateFile,
reader, int64(0))
On 2013/07/18 14:17:28, rog wrote:
> s/int64(0)/0/
> (no need for the explicit type)

+1

https://codereview.appspot.com/11462044/diff/1/environs/azure/environ.go#newc...
environs/azure/environ.go:149: return nil, fmt.Errorf("cannot create bootstrap
state file: %v", err)
On 2013/07/18 14:17:28, rog wrote:
> "cannot get URL for bootstrap state file: %v"

+1

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

[dimitern, 2013-07-18 14:29:13]

LGTM with some of Roger's comments.

[rvb, 2013-07-18 14:30:39]

> > All done, thanks for the review!
> 
> i don't see the changes yet...

When I run "lbox propose" twice a new MP gets created everytime…