Issue 114600044: Fix to saving message drafts (the "M" keystroke)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 114600044: Fix to saving message drafts (the "M" keystroke) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by jrobbins (chromium)

Modified:
9 years, 2 months ago

Reviewers:
jrobbins (corp), iannucci, ingram.jody3211

CC:
codereview-list_groups.google.com

Visibility:
Public.

More Reviews

Description

_post_draft_message() is not a request handler and was not called with the arguments needed to make @deco.issue_required work. Since it is only called from draft_message() which itself has @deco.issue_required, I can just delete that decorator here. I intend to commit this to both the default and chromium branches.

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	codereview/views.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jrobbins (chromium)

PTAL. This gets a long-broken feature working again.

9 years, 8 months ago (2014-08-05 18:12:43 UTC) #1

jrobbins (corp)

On 2014/08/05 18:40:53, iannucci wrote: > lgtm Committed as https://code.google.com/p/rietveld/source/detail?r=07ecb4928ff2e2ef2cf5ba029bcd6fd93727601a

9 years, 8 months ago (2014-08-05 18:54:16 UTC) #3

Message was sent while issue was closed.

Expand All Messages | Collapse All Messages