Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 11455045: code review 11455045: [release-branch.go1.1] cmd/gc: fix pointer composite li... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by adg
Modified:
9 years, 2 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: fix pointer composite literals in exported if statements. ««« CL 10470043 / d04e6b0bcacf cmd/gc: fix pointer composite literals in exported if statements. Fixes issue 4230 (again). R=rsc, golang-dev, r CC=golang-dev https://codereview.appspot.com/10470043 »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r a7bd9a33067b https://code.google.com/p/go #

Patch Set 3 : diff -r a7bd9a33067b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug465.dir/a.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M test/fixedbugs/bug465.dir/b.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 2 months ago (2013-07-22 08:17:41 UTC) #1
dfc
LGTM. On 22/07/2013, at 18:17, adg@golang.org wrote: > Reviewers: golang-dev1, > > Message: > Hello ...
9 years, 2 months ago (2013-07-22 08:19:58 UTC) #2
adg
9 years, 2 months ago (2013-07-22 08:22:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=31a32150a72b ***

[release-branch.go1.1] cmd/gc: fix pointer composite literals in exported if
statements.

««« CL 10470043 / d04e6b0bcacf
cmd/gc: fix pointer composite literals in exported if statements.

Fixes issue 4230 (again).

R=rsc, golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10470043
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11455045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b