code review 114510043: cmd/ld: better diagnostics on unaligned symbols

cmd/ld: better diagnostics on unaligned symbols
Want to see why builders are failing.
Then decide whether to rollback or fix.

[dvyukov, 2014-07-29 07:19:57]

Hello khr@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2014-07-29 07:23:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=cd8dbfda7b87 ***

cmd/ld: better diagnostics on unaligned symbols
Want to see why builders are failing.
Then decide whether to rollback or fix.

TBR=khr
R=khr
CC=golang-codereviews
https://codereview.appspot.com/114510043

[dvyukov, 2014-07-29 07:32:35]

does anybody know what is that recv$8 and where does it come from?


On Tue, Jul 29, 2014 at 11:23 AM,  <dvyukov@google.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=cd8dbfda7b87 ***
>
>
> cmd/ld: better diagnostics on unaligned symbols
> Want to see why builders are failing.
> Then decide whether to rollback or fix.
>
> TBR=khr
> R=khr
> CC=golang-codereviews
> https://codereview.appspot.com/114510043
>
>
> https://codereview.appspot.com/114510043/

[brainman, 2014-07-29 07:40:20]

I don't know, but

# go tool nm ~/go/root/bin/go | grep 'recv\$8'
 85673a0 d recv$8

marked as data.

Alex

[dave_cheney.net, 2014-07-29 07:58:44]

linux/arm blames

cmd/go
proggenaddsym: unaligned conservative symbol conditions: size=5 pos=868



On Tue, Jul 29, 2014 at 5:40 PM, <alex.brainman@gmail.com> wrote:

> I don't know, but
>
> # go tool nm ~/go/root/bin/go | grep 'recv\$8'
>  85673a0 d recv$8
>
> marked as data.
>
> Alex
>
>
> https://codereview.appspot.com/114510043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[gobot, 2014-07-29 08:02:24]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/3fe9a42b5c50ed0006363653f41c2da0c941a926

[dvyukov, 2014-07-29 08:10:21]

I see it, it's static recv variable in sigqueue_recv.
All these symbols needs to be marked as NOPTR.


On Tue, Jul 29, 2014 at 11:40 AM,  <alex.brainman@gmail.com> wrote:
> I don't know, but
>
> # go tool nm ~/go/root/bin/go | grep 'recv\$8'
>  85673a0 d recv$8
>
> marked as data.
>
> Alex
>
> https://codereview.appspot.com/114510043/

[dvyukov, 2014-07-29 08:15:33]

On Tue, Jul 29, 2014 at 11:58 AM, Dave Cheney <dave@cheney.net> wrote:
> linux/arm blames
>
> cmd/go
> proggenaddsym: unaligned conservative symbol conditions: size=5 pos=868

cl/120280044 for this

>
>
>
> On Tue, Jul 29, 2014 at 5:40 PM, <alex.brainman@gmail.com> wrote:
>>
>> I don't know, but
>>
>> # go tool nm ~/go/root/bin/go | grep 'recv\$8'
>>  85673a0 d recv$8
>>
>> marked as data.
>>
>> Alex
>>
>>
>> https://codereview.appspot.com/114510043/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>

[dvyukov, 2014-07-29 08:15:53]

cl 119300043 for this

On Tue, Jul 29, 2014 at 12:10 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> I see it, it's static recv variable in sigqueue_recv.
> All these symbols needs to be marked as NOPTR.
>
>
> On Tue, Jul 29, 2014 at 11:40 AM,  <alex.brainman@gmail.com> wrote:
>> I don't know, but
>>
>> # go tool nm ~/go/root/bin/go | grep 'recv\$8'
>>  85673a0 d recv$8
>>
>> marked as data.
>>
>> Alex
>>
>> https://codereview.appspot.com/114510043/