Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 11447043: Related charms pull updated commitCount value.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by rharding
Modified:
7 years, 3 months ago
Reviewers:
mp+175304, matthew.scott, gary.poster
Visibility:
Public.

Description

Related charms pull updated commitCount value. - The charmworld api is updated to provide a limited code_source attribute to provide the revno. - The gui needs to pull that into the related charm data and output it in the charm token for related charms. https://code.launchpad.net/~rharding/juju-gui/fix-related-commits-1202029/+merge/175304 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Related charms pull updated commitCount value. #

Patch Set 3 : Related charms pull updated commitCount value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2981 lines, -49 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/data/related.json View 14 chunks +2976 lines, -46 lines 0 comments Download
M test/test_browser_charm_details.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
7 years, 3 months ago (2013-07-17 14:45:34 UTC) #1
matthew.scott
LGTM, thanks!
7 years, 3 months ago (2013-07-17 16:22:43 UTC) #2
gary.poster
LGTM
7 years, 3 months ago (2013-07-17 18:45:17 UTC) #3
rharding
7 years, 3 months ago (2013-07-17 20:03:08 UTC) #4
*** Submitted:

Related charms pull updated commitCount value.

- The charmworld api is updated to provide a limited code_source attribute to
provide the revno.
- The gui needs to pull that into the related charm data and output it in the
charm token for related charms.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/11447043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b