Changes `Charm` model to use `options`

Changes `Charm` model to use `options`

The `Charm` model has an attr named `config`, which only stores an `options`
object. `BrowserCharm` just has the `options` attr. To make the two models more
compatible towards finally merging them, this replaces the `config` with `options`
in `Charm`.

This was done largely by multiple passes scanning for uses of the two
attributes--because of several cases where the charm's config is abstracted from
the model, and other cases where config is used b/c no model is ever created,
it's possible that spots were missed.

https://code.launchpad.net/~jcsackett/juju-gui/old-charm-meet-new-charm/+merge/175283

(do not edit description out of merge proposal)

[j.c.sackett, 2013-07-17 13:47:13]

Please take a look.

[rharding, 2013-07-17 14:10:53]

LGTM with one request for readability.

https://codereview.appspot.com/11443043/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/11443043/diff/1/test/test_model.js#newcode41
test/test_model.js:41: it('can load options from both \'options\' and
\'config\'', function() {
I'd find this easier to read if it was just " vs \'

[j.c.sackett, 2013-07-17 14:12:10]

On 2013/07/17 14:10:53, rharding wrote:
> LGTM with one request for readability.
> 
> https://codereview.appspot.com/11443043/diff/1/test/test_model.js
> File test/test_model.js (right):
> 
> https://codereview.appspot.com/11443043/diff/1/test/test_model.js#newcode41
> test/test_model.js:41: it('can load options from both \'options\' and
> \'config\'', function() {
> I'd find this easier to read if it was just " vs \'

Sure; saw this pattern used in a couple of tests and it evidently got stuck in
my head.

[j.c.sackett, 2013-07-17 14:19:29]

Please take a look.

[matthew.scott, 2013-07-17 16:18:02]

LGTM \o/

https://codereview.appspot.com/11443043/diff/6002/test/test_charm_configurati...
File test/test_charm_configuration.js (right):

https://codereview.appspot.com/11443043/diff/6002/test/test_charm_configurati...
test/test_charm_configuration.js:23: charmConfig = {
Thank yooou

[j.c.sackett, 2013-07-17 18:21:58]

*** Submitted:

Changes `Charm` model to use `options`

The `Charm` model has an attr named `config`, which only stores an `options`
object. `BrowserCharm` just has the `options` attr. To make the two models more
compatible towards finally merging them, this replaces the `config` with
`options`
in `Charm`.

This was done largely by multiple passes scanning for uses of the two
attributes--because of several cases where the charm's config is abstracted from
the model, and other cases where config is used b/c no model is ever created,
it's possible that spots were missed.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/11443043