Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2738)

Issue 11433048: Databinding unbind redux

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by bcsaller
Modified:
10 years, 9 months ago
Reviewers:
mp+175923, matthew.scott, rharding
Visibility:
Public.

Description

Databinding unbind redux The ongoing battle continues. https://code.launchpad.net/~bcsaller/juju-gui/detachfix/+merge/175923 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Databinding unbind redux #

Patch Set 3 : Databinding unbind redux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/databinding.js View 3 chunks +5 lines, -4 lines 0 comments Download
M test/test_databinding.js View 1 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5
bcsaller
Please take a look.
10 years, 9 months ago (2013-07-19 18:57:29 UTC) #1
rharding
LGTM, thanks a ton for helping with this!
10 years, 9 months ago (2013-07-19 19:01:35 UTC) #2
matthew.scott
LGTM. thanks!
10 years, 9 months ago (2013-07-19 19:19:07 UTC) #3
bcsaller
Please take a look.
10 years, 9 months ago (2013-07-19 19:58:03 UTC) #4
bcsaller
10 years, 9 months ago (2013-07-19 20:07:42 UTC) #5
*** Submitted:

Databinding unbind redux

The ongoing battle continues.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/11433048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b