code review 11421043: doc/effective_go: stamp out stray GOROOT reference

doc/effective_go: stamp out stray GOROOT reference

Replaced with something more appropriate.

[dave_cheney.net, 2013-07-17 06:13:14]

Hello adg@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-07-17 06:13:59]

I'm amazed how people keep finding these buggers and extrapolating
from there to a broken Go install.

On Wed, Jul 17, 2013 at 4:13 PM,  <dave@cheney.net> wrote:
> Reviewers: adg, r,
>
> Message:
> Hello adg@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> doc/effecitve_go: stamp out stray GOROOT reference
>
> Replaced with something more appropriate.
>
> Please review this at https://codereview.appspot.com/11421043/
>
> Affected files:
>   M doc/effective_go.html
>
>
> Index: doc/effective_go.html
> ===================================================================
> --- a/doc/effective_go.html
> +++ b/doc/effective_go.html
> @@ -1915,7 +1915,7 @@
>  var (
>      home   = os.Getenv("HOME")
>      user   = os.Getenv("USER")
> -    goRoot = os.Getenv("GOROOT")
> +    gopath = os.Getenv("GOPATH")
>  )
>  </pre>
>
> @@ -1944,11 +1944,11 @@
>      if home == "" {
>          home = "/home/" + user
>      }
> -    if goRoot == "" {
> -        goRoot = home + "/go"
> +    if gopath == "" {
> +        gopath = home + "/go"
>      }
> -    // goRoot may be overridden by --goroot flag on command line.
> -    flag.StringVar(&amp;goRoot, "goroot", goRoot, "Go root directory")
> +    // gopath may be overridden by --gopath flag on command line.
> +    flag.StringVar(&amp;gopath, "gopath", gopath, "override default
> GOPATH")
>  }
>  </pre>
>
>
>

[minux1, 2013-07-17 06:34:36]

should the variable be goPath or gopath?

otherwise, LGTM.

[dave_cheney.net, 2013-07-17 06:37:36]

I chose to call it `gopath` as that is more common inside the source
base, goRoot was quite unusual.

On Wed, Jul 17, 2013 at 4:34 PM, minux <minux.ma@gmail.com> wrote:
> should the variable be goPath or gopath?
>
> otherwise, LGTM.

[r, 2013-07-17 06:53:41]

LGTM but fix typo in CL description

[dave_cheney.net, 2013-07-17 08:49:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=28a2612c7ff1 ***

doc/effective_go: stamp out stray GOROOT reference

Replaced with something more appropriate.

R=adg, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/11421043