Moved comments to right and meta-data to left in modify/submit view of tickets and also removed the…

Moved comments to right and meta-data to left in modify/submit view of tickets and also removed the…

[dimazest, 2014-07-22 13:44:27]

https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/base.html (right):

https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/base.html:114: <br>
do you need <br>?

[sksaurabhkathpalia, 2014-07-22 13:46:20]

https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/base.html (right):

https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/base.html:114: <br>
On 2014/07/22 13:44:27, dimazest wrote:
> do you need <br>?

Removal of this won't do much difference,
removing it

[RogerHaase, 2014-07-22 15:02:53]

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/stylu...
File MoinMoin/static/css/stylus/ticket.styl (right):

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/stylu...
MoinMoin/static/css/stylus/ticket.styl:108: width 60%
imho, the widths should be reversed.  Not much room in the comments area if the
comment to be entered is a copy and paste traceback or similar block of code

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticke...
File MoinMoin/static/css/ticket.css (right):

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticke...
MoinMoin/static/css/ticket.css:11: .moin-ticket-comments{float:right;width:40%}
while the current change looks OK, the change from 3 weeks ago looks unreadable

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/modify.html (right):

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/modify.html:12: {{ gen.textarea(form['message'],
rows='5', class='form-control') }}
can the rows=5 be done in CSS?

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/submit.html (right):

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/submit.html:13: {{ gen.textarea(form['message'],
rows='5', class='form-control') }}
can CSS do the rows=5?

[sksaurabhkathpalia, 2014-07-22 15:24:33]

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticke...
File MoinMoin/static/css/ticket.css (right):

https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticke...
MoinMoin/static/css/ticket.css:11: .moin-ticket-comments{float:right;width:40%}
On 2014/07/22 15:02:52, RogerHaase wrote:
> while the current change looks OK, the change from 3 weeks ago looks
unreadable

Actually in the earlier commit I was required to define css for the 5 types
radio buttons (e.g. #f_meta_effort1, #f_meta_effort2 etc) so the css file became
a bit non readable but if you read ticket.styl, it is quite readable

[RogerHaase, 2014-07-23 14:27:46]

looks OK to me

[Thomas.J.Waldmann, 2014-07-31 15:14:08]

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/modify.html (right):

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/modify.html:24: {{ _("Suggested Tags: ") }}
strange that the translated string has trailing blank (maybe not your fault)

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/submit.html (right):

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/submit.html:4: {{ _("Creating new ticket") }}
Create new ticket
or
Creating new ticket
?

[sksaurabhkathpalia, 2014-07-31 15:16:29]

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/submit.html (right):

https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/submit.html:4: {{ _("Creating new ticket") }}
On 2014/07/31 15:14:08, Thomas.J.Waldmann wrote:
> Create new ticket
> or
> Creating new ticket
> ?

Yeah may be create ticket looks better

[Thomas.J.Waldmann, 2014-08-04 17:42:16]

src looks ok.

[Thomas.J.Waldmann, 2014-08-07 15:14:26]

ok