Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4442)

Issue 114210043: Moved comments to right and meta-data to left in modify/submit view of tickets and also removed the… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by sksaurabhkathpalia
Modified:
9 years, 8 months ago
Reviewers:
thomas.j.waldmann, dimazest, RogerHaase
Visibility:
Public.

Description

Moved comments to right and meta-data to left in modify/submit view of tickets and also removed the…

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Corrected indentation in ticket.styl #

Total comments: 2

Patch Set 4 : Removed br tag #

Total comments: 5

Patch Set 5 : Removed rows='5' and reveresed the widths of comments and meta-data section #

Patch Set 6 : minor indentation change #

Total comments: 3

Patch Set 7 : Used create instead of creating in submit template of tickets #

Patch Set 8 : Updated cr as per the current repo #

Patch Set 9 : Used div instead of dl to remove HTML validation errors #

Patch Set 10 : Used summary instead of name in heading in ticket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -28 lines) Patch
M MoinMoin/static/css/stylus/ticket.styl View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M MoinMoin/static/css/ticket.css View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/base.html View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M MoinMoin/templates/ticket/modify.html View 1 2 3 4 5 6 7 8 9 1 chunk +26 lines, -21 lines 0 comments Download
M MoinMoin/templates/ticket/submit.html View 1 2 3 4 5 6 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9
dimazest
https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket/base.html File MoinMoin/templates/ticket/base.html (right): https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket/base.html#newcode114 MoinMoin/templates/ticket/base.html:114: <br> do you need <br>?
9 years, 9 months ago (2014-07-22 13:44:27 UTC) #1
sksaurabhkathpalia
https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket/base.html File MoinMoin/templates/ticket/base.html (right): https://codereview.appspot.com/114210043/diff/30001/MoinMoin/templates/ticket/base.html#newcode114 MoinMoin/templates/ticket/base.html:114: <br> On 2014/07/22 13:44:27, dimazest wrote: > do you ...
9 years, 9 months ago (2014-07-22 13:46:20 UTC) #2
RogerHaase
https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/stylus/ticket.styl File MoinMoin/static/css/stylus/ticket.styl (right): https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/stylus/ticket.styl#newcode108 MoinMoin/static/css/stylus/ticket.styl:108: width 60% imho, the widths should be reversed. Not ...
9 years, 9 months ago (2014-07-22 15:02:53 UTC) #3
sksaurabhkathpalia
https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticket.css File MoinMoin/static/css/ticket.css (right): https://codereview.appspot.com/114210043/diff/50001/MoinMoin/static/css/ticket.css#newcode11 MoinMoin/static/css/ticket.css:11: .moin-ticket-comments{float:right;width:40%} On 2014/07/22 15:02:52, RogerHaase wrote: > while the ...
9 years, 9 months ago (2014-07-22 15:24:33 UTC) #4
RogerHaase
looks OK to me
9 years, 9 months ago (2014-07-23 14:27:46 UTC) #5
Thomas.J.Waldmann
https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket/modify.html File MoinMoin/templates/ticket/modify.html (right): https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket/modify.html#newcode24 MoinMoin/templates/ticket/modify.html:24: {{ _("Suggested Tags: ") }} strange that the translated ...
9 years, 9 months ago (2014-07-31 15:14:08 UTC) #6
sksaurabhkathpalia
https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket/submit.html File MoinMoin/templates/ticket/submit.html (right): https://codereview.appspot.com/114210043/diff/90001/MoinMoin/templates/ticket/submit.html#newcode4 MoinMoin/templates/ticket/submit.html:4: {{ _("Creating new ticket") }} On 2014/07/31 15:14:08, Thomas.J.Waldmann ...
9 years, 9 months ago (2014-07-31 15:16:29 UTC) #7
Thomas.J.Waldmann
src looks ok.
9 years, 8 months ago (2014-08-04 17:42:16 UTC) #8
Thomas.J.Waldmann
9 years, 8 months ago (2014-08-07 15:14:26 UTC) #9
ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b