Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(576)

Issue 114140043: code review 114140043: syscall: allow for mksyscall_windows.go to be used outs... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by brainman
Modified:
6 years, 6 months ago
Reviewers:
gobot, chris.hines
CC:
golang-codereviews, chris.hines, josharian
Visibility:
Public.

Description

syscall: allow for mksyscall_windows.go to be used outside of syscall Fixes issue 8398.

Patch Set 1 #

Patch Set 2 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 82cbf874e066 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 6a4157362cfd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M src/pkg/syscall/mksyscall_windows.go View 9 chunks +45 lines, -12 lines 0 comments Download

Messages

Total messages: 8
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 6 months ago (2014-07-21 06:15:46 UTC) #1
chris.hines
See inline comments for two missing calls to syscalldot(). https://codereview.appspot.com/114140043/diff/40001/src/pkg/syscall/mksyscall_windows.go File src/pkg/syscall/mksyscall_windows.go (right): https://codereview.appspot.com/114140043/diff/40001/src/pkg/syscall/mksyscall_windows.go#newcode520 src/pkg/syscall/mksyscall_windows.go:520: ...
6 years, 6 months ago (2014-07-21 18:47:04 UTC) #2
brainman
Hello golang-codereviews@googlegroups.com, chines@comscore.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 6 months ago (2014-07-22 05:36:12 UTC) #3
brainman
Thank you for review. PTAL. Alex https://codereview.appspot.com/114140043/diff/40001/src/pkg/syscall/mksyscall_windows.go File src/pkg/syscall/mksyscall_windows.go (right): https://codereview.appspot.com/114140043/diff/40001/src/pkg/syscall/mksyscall_windows.go#newcode520 src/pkg/syscall/mksyscall_windows.go:520: return "UTF16PtrFromString" On ...
6 years, 6 months ago (2014-07-22 05:36:18 UTC) #4
chris.hines
On 2014/07/22 05:36:18, brainman wrote: > Thank you for review. PTAL. > > Alex > ...
6 years, 6 months ago (2014-07-22 13:07:46 UTC) #5
josharian
https://codereview.appspot.com/114140043/diff/60001/src/pkg/syscall/mksyscall_windows.go File src/pkg/syscall/mksyscall_windows.go (right): https://codereview.appspot.com/114140043/diff/60001/src/pkg/syscall/mksyscall_windows.go#newcode607 src/pkg/syscall/mksyscall_windows.go:607: pkg, err := parser.ParseFile(fset, "", file, parser.ImportsOnly) Drive-by nitpick: ...
6 years, 6 months ago (2014-07-22 20:19:00 UTC) #6
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=ef2344f636e4 *** syscall: allow for mksyscall_windows.go to be used outside of syscall ...
6 years, 6 months ago (2014-07-23 02:36:43 UTC) #7
gobot
6 years, 6 months ago (2014-07-23 02:49:12 UTC) #8
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/eb239441bc0fd896b3224a946e0a8d31bc858950
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b