Issue 11406047: code review 11406047: cmd/cgo: gccgo fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11406047: code review 11406047: cmd/cgo: gccgo fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by iant

Modified:
10 years, 9 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/cgo: gccgo fixes Don't require a full-scale callback for calls to the special prologue functions. Always use a simple wrapper function for C functions, so that we can handle static functions defined in the import "C" comment. Disable a test that relies on gc-specific function names. Fixes issue 5905.

Patch Set 1 #

Patch Set 2 : diff -r fad8f3d28e19 https://code.google.com/p/go #

Patch Set 3 : diff -r afb591d143cd https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -6 lines)			Patch
	M	misc/cgo/test/callback.go	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/out.go	View	1 2	6 chunks	+62 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2013-07-22 23:41:07 UTC) #1

iant

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2013-07-22 23:42:02 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=4d9c3095de9d *** cmd/cgo: gccgo fixes Don't require a full-scale callback for calls ...

11 years, 5 months ago (2013-07-25 13:54:00 UTC) #5

*** Abandoned ***

Expand All Messages | Collapse All Messages