Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(616)

Issue 114060043: Shared RngStream

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Peter Barnes
Modified:
6 years, 2 months ago
Reviewers:
Tom Henderson, barnes26, Tommaso Pecorella
CC:
ns-developers_isi.edu, ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

There are many cases where you want to use several different rng distributions, but you only want to manage one seed when doing replicated runs. This patch allows several RandomVariableStreams to use the same underlying RngStream.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement ShareStream. Hide RngStream from public API. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -103 lines) Patch
M CHANGES.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M RELEASE_NOTES View 1 1 chunk +2 lines, -0 lines 0 comments Download
M doc/manual/source/random-variables.rst View 1 12 chunks +123 lines, -48 lines 1 comment Download
M src/core/model/random-variable-stream.h View 1 3 chunks +12 lines, -18 lines 2 comments Download
M src/core/model/random-variable-stream.cc View 1 15 chunks +20 lines, -35 lines 0 comments Download
M src/core/model/rng-stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/wscript View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11
barnes26_llnl.gov
There are many cases where you want to use several different rng distributions, but you ...
6 years, 3 months ago (2014-07-21 17:41:08 UTC) #1
Tommaso Pecorella
On 2014/07/21 17:41:08, barnes26_llnl.gov wrote: > There are many cases where you want to use ...
6 years, 3 months ago (2014-07-21 18:00:04 UTC) #2
Tommaso Pecorella
https://codereview.appspot.com/114060043/diff/1/src/core/model/rng-stream.h File src/core/model/rng-stream.h (right): https://codereview.appspot.com/114060043/diff/1/src/core/model/rng-stream.h#newcode71 src/core/model/rng-stream.h:71: * \param [in] o Other RngStream this is "\param ...
6 years, 3 months ago (2014-07-21 18:00:27 UTC) #3
Tom Henderson
I don't see the need for this patch, can you elaborate? Each RandomVariableStream object has ...
6 years, 3 months ago (2014-07-21 21:54:04 UTC) #4
barnes26_llnl.gov
On Jul 21, 2014, at 2:54 PM, tomh.org@gmail.com wrote: > I don't see the need ...
6 years, 3 months ago (2014-07-22 22:46:54 UTC) #5
Tom Henderson
On 2014/07/22 22:46:54, barnes26_llnl.gov wrote: > On Jul 21, 2014, at 2:54 PM, mailto:tomh.org@gmail.com wrote: ...
6 years, 3 months ago (2014-07-23 07:07:30 UTC) #6
Tom Henderson
In thinking about this more, clearly this provides more granular control on RngStream assignment than ...
6 years, 3 months ago (2014-07-23 13:58:10 UTC) #7
barnes26_llnl.gov
On Jul 23, 2014, at 12:07 AM, tomh.org@gmail.com wrote: > On 2014/07/22 22:46:54, barnes26_llnl.gov wrote: ...
6 years, 3 months ago (2014-07-28 19:39:59 UTC) #8
Peter Barnes
Implement ShareStream; hide RngStream from public API.
6 years, 2 months ago (2014-08-11 23:00:51 UTC) #9
Peter Barnes
On 2014/08/11 23:00:51, Peter Barnes wrote: > Implement ShareStream; hide RngStream from public API. Bump ...
6 years, 2 months ago (2014-08-13 21:34:42 UTC) #10
Tom Henderson
6 years, 2 months ago (2014-08-15 14:13:42 UTC) #11
New API is fine with me, documentation is improved.  Example code and test could
follow.

https://codereview.appspot.com/114060043/diff/1/src/core/model/rng-stream.h
File src/core/model/rng-stream.h (right):

https://codereview.appspot.com/114060043/diff/1/src/core/model/rng-stream.h#n...
src/core/model/rng-stream.h:38: * For a give seed the period of the entire
generator is approximately
s/give/given

https://codereview.appspot.com/114060043/diff/20001/doc/manual/source/random-...
File doc/manual/source/random-variables.rst (right):

https://codereview.appspot.com/114060043/diff/20001/doc/manual/source/random-...
doc/manual/source/random-variables.rst:351: stream numbers.
add to end of this sentence:  "or assigned automatically by the simulator when
AssignStreams() is not used."

https://codereview.appspot.com/114060043/diff/20001/src/core/model/random-var...
File src/core/model/random-variable-stream.h (right):

https://codereview.appspot.com/114060043/diff/20001/src/core/model/random-var...
src/core/model/random-variable-stream.h:136: * configured stream number.
s/stream number/stream index

https://codereview.appspot.com/114060043/diff/20001/src/core/model/random-var...
src/core/model/random-variable-stream.h:153: Ptr<RngStream> m_rng;
Is this just a style (non-technical) change?  Just curious.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b