Issue 113970044: code review 113970044: cmd/ld: consistently document flags that expect values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113970044: code review 113970044: cmd/ld: consistently document flags that expect values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mdempsky

Modified:
11 years, 4 months ago

Reviewers:
minux, rsc

CC:
golang-codereviews, minux, rsc

Visibility:
Public.

Description

cmd/ld: consistently document flags that expect values

Patch Set 1 #

Patch Set 2 : diff -r 6866fbf95095 https://code.google.com/p/go #

Patch Set 3 : diff -r 6866fbf95095 https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/cmd/ld/pobj.c	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mdempsky

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2014-07-15 20:49:17 UTC) #1

minux

LGTM. Please made the the description read "cmd/ld:" instead of "ld:".

11 years, 5 months ago (2014-07-15 20:51:51 UTC) #2

mdempsky

On 2014/07/15 20:51:51, minux wrote: > Please made the the description read "cmd/ld:" instead of ...

11 years, 5 months ago (2014-07-15 20:52:58 UTC) #3

minux

This is a simple docs change, but as the compiler is still frozen, I will ...

11 years, 5 months ago (2014-07-15 20:58:41 UTC) #4

minux

11 years, 5 months ago (2014-07-15 21:05:39 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=65ce0df44258 ***

cmd/ld: consistently document flags that expect values

LGTM=minux, rsc
R=golang-codereviews, minux, rsc
CC=golang-codereviews
https://codereview.appspot.com/113970044

Committer: Shenghou Ma <minux@golang.org>

Expand All Messages | Collapse All Messages