Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 11385045: code review 11385045: runtime: print g0 stack if we throw on it and GOTRACEBA... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by khr
Modified:
11 years, 11 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: print g0 stack if we throw on it and GOTRACEBACK>=2.

Patch Set 1 #

Patch Set 2 : diff -r 07c23baa9f0b https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 07c23baa9f0b https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 15b6bb549e20 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/pkg/runtime/panic.c View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 11 months ago (2013-07-16 22:02:26 UTC) #1
rsc
LGTM Please avoid the implicit comparison with zero. It's a little easier to read later, ...
11 years, 11 months ago (2013-07-16 23:37:40 UTC) #2
khr
11 years, 11 months ago (2013-07-16 23:44:26 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=95e1e4bd8da9 ***

runtime: print g0 stack if we throw on it and GOTRACEBACK>=2.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11385045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b