Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7331)

Issue 113850043: Added css for +tickets view for modernized theme also moved images of table-sorter to MoinMoin/stat… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by sksaurabhkathpalia
Modified:
9 years, 9 months ago
Reviewers:
dimazest, RogerHaase
Visibility:
Public.

Description

Added css for +tickets view for modernized theme also moved images of table-sorter to MoinMoin/stat…

Patch Set 1 #

Patch Set 2 : minor change #

Patch Set 3 : #

Patch Set 4 : Corrected indentation and defined css for sort button #

Patch Set 5 : minor change #

Messages

Total messages: 3
dimazest
looks good, but wait for TW or someone else review
9 years, 9 months ago (2014-07-14 11:02:14 UTC) #1
RogerHaase
the cr looks like you are adding asc.png, desc.png, etc to both MoinMoin/static/ims and basic/static/img, ...
9 years, 9 months ago (2014-07-14 16:00:28 UTC) #2
sksaurabhkathpalia
9 years, 9 months ago (2014-07-14 16:05:56 UTC) #3
On 2014/07/14 16:00:28, RogerHaase wrote:
> the cr looks like you are adding asc.png, desc.png, etc to both
> MoinMoin/static/ims and basic/static/img, but only using the ones in
> MoinMoin/static/img (correct).
> 
> Hopefully the cr is screwed up and you are removing the ones already stored
> within basic/static/img

No I have removed desc.png, asc.png, bg.png and search.png from
themes/basic/static/img and moved that to MoinMoin/static/img so that it can be
used by all themes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b