Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 113830043: Improved UI of Blog Items (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by sksaurabhkathpalia
Modified:
9 years, 7 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

Improved UI of Blog Items

Patch Set 1 #

Patch Set 2 : Corrected Indentation #

Total comments: 5

Patch Set 3 : Used fqname instead of name in the link and chenged Modify entry to Modify and also added a TODO #

Patch Set 4 : Updated cr as per the current repo and replaced the usage of name with fqname in user.may.write #

Total comments: 1

Patch Set 5 : Used summary instead of title #

Total comments: 1

Patch Set 6 : Some error was introduced in this changeset #

Patch Set 7 : Removed the else statement of printing "Not Published yet" #

Patch Set 8 : Made some minor changes in css due to ticket-create button and also changed id of blog-entry to moi… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -35 lines) Patch
M MoinMoin/templates/blog/utils.html View 1 2 3 4 5 6 7 1 chunk +36 lines, -35 lines 0 comments Download
A MoinMoin/themes/basic/static/css/blog.css View 1 2 3 4 5 6 7 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Thomas.J.Waldmann
https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html File MoinMoin/templates/blog/utils.html (right): https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html#newcode16 MoinMoin/templates/blog/utils.html:16: <a href="{{ url_for('frontend.modify_item', item_name=entry_item.name) }}">{{ _("Modify entry") }}</a> if ...
9 years, 8 months ago (2014-07-12 16:23:11 UTC) #1
sksaurabhkathpalia
https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html File MoinMoin/templates/blog/utils.html (right): https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html#newcode25 MoinMoin/templates/blog/utils.html:25: {{ _("Not published yet.") }} On 2014/07/12 16:23:11, Thomas.J.Waldmann ...
9 years, 8 months ago (2014-07-24 06:34:29 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html File MoinMoin/templates/blog/utils.html (right): https://codereview.appspot.com/113830043/diff/20001/MoinMoin/templates/blog/utils.html#newcode25 MoinMoin/templates/blog/utils.html:25: {{ _("Not published yet.") }} > > can that ...
9 years, 8 months ago (2014-08-02 17:47:08 UTC) #3
Thomas.J.Waldmann
https://codereview.appspot.com/113830043/diff/80001/MoinMoin/templates/blog/utils.html File MoinMoin/templates/blog/utils.html (right): https://codereview.appspot.com/113830043/diff/80001/MoinMoin/templates/blog/utils.html#newcode21 MoinMoin/templates/blog/utils.html:21: {{ _("Not published yet.") }} still not fixed
9 years, 7 months ago (2014-08-04 17:38:56 UTC) #4
Thomas.J.Waldmann
9 years, 7 months ago (2014-08-04 18:44:28 UTC) #5
ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b