code review 11373044: cmd/gc: fix inlining of unnamed structs with embedded f...

cmd/gc: fix inlining of unnamed structs with embedded fields.

Update issue 5910.

[remyoudompheng, 2013-07-27 21:48:09]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[DMorsing, 2013-07-28 05:51:49]

LGTM.

[remyoudompheng, 2013-08-03 09:13:12]

On 2013/07/28 05:51:49, DMorsing wrote:
> LGTM.

I'd like the opnion of someone else for this change.
Note that it doesn't handle the problem of embeedded builtins, which I think is
larger and separate.

[DMorsing, 2013-08-03 10:23:04]

On 2013/08/03 09:13:12, remyoudompheng wrote:
> On 2013/07/28 05:51:49, DMorsing wrote:
> > LGTM.
> 
> I'd like the opnion of someone else for this change.
> Note that it doesn't handle the problem of embeedded builtins, which I think
is
> larger and separate.

Fine by me.

Talking about issue 5974, right? I haven't worked on that since I identified the
symbol table weirdness.

[remyoudompheng, 2013-08-05 19:56:32]

On 2013/08/03 10:23:04, DMorsing wrote:
> On 2013/08/03 09:13:12, remyoudompheng wrote:
> > On 2013/07/28 05:51:49, DMorsing wrote:
> > > LGTM.
> > 
> > I'd like the opnion of someone else for this change.
> > Note that it doesn't handle the problem of embeedded builtins, which I think
> is
> > larger and separate.
> 
> Fine by me.
> 
> Talking about issue 5974, right? I haven't worked on that since I identified
the
> symbol table weirdness.

Submitting this in 10 minutes.

[rsc, 2013-08-05 20:03:32]

LGTM

[remyoudompheng, 2013-08-05 20:10:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=56696c13acef ***

cmd/gc: fix inlining of unnamed structs with embedded fields.

Update issue 5910.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/11373044

[dave_cheney.net, 2013-08-05 22:05:07]

> Update issue 5910.

nit: the trailing period causes the failure to update issue 5910.