Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12346)

Issue 113730043: Respond to some of Steve Kent's comments

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by Ben Laurie (Google)
Modified:
9 years, 9 months ago
Reviewers:
Eran
CC:
Rob Stradling
Visibility:
Public.

Description

Respond to some of Steve Kent's comments

Patch Set 1 #

Total comments: 6

Patch Set 2 : Respond to Rob's (offline) comments #

Patch Set 3 : Re-push #

Patch Set 4 : re-re-push #

Patch Set 5 : Fix Eran's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M rfc6962-bis.xml View 1 2 3 4 12 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 3
Eran
LGTM modulu the issue of figuring out which SCT belong to which certificate in the ...
9 years, 9 months ago (2014-07-10 13:49:52 UTC) #1
Ben Laurie (Google)
https://codereview.appspot.com/113730043/diff/1/rfc6962-bis.xml File rfc6962-bis.xml (right): https://codereview.appspot.com/113730043/diff/1/rfc6962-bis.xml#newcode402 rfc6962-bis.xml:402: <spanx style="verb">certificate_chain</spanx> is a chain of additional certificates required ...
9 years, 9 months ago (2014-07-10 14:19:36 UTC) #2
Eran
9 years, 9 months ago (2014-07-10 15:36:49 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b