Issue 113720043: enables ftests on local env

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113720043: enables ftests on local env

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by uros.jovanovic

Modified:
9 years, 9 months ago

Reviewers:
jay.wren, mp+226270

Visibility:
Public.

Description

enables ftests on local env Create local environment (with "local" also being the name of that environment) and ftests can be now be run local as well. https://code.launchpad.net/~uros-jovanovic/charms/trusty/juju-gui/hackingreview/+merge/226270 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : minor change in hacking.md #

Total comments: 2

Patch Set 3 : minor change in hacking.md #

Patch Set 4 : minor change in hacking.md #

Patch Set 5 : enables ftests on local env #

Patch Set 6 : enables ftests on local env #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
M	HACKING.md	View	1 2	2 chunks	+17 lines, -4 lines	0 comments	Download
M	Makefile	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/20-functional.test	View	1 2 3	3 chunks	+12 lines, -1 line	0 comments	Download
M	tests/deploy.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

rharding

Couple of comments, will let Jay do the final looks good approval based on successful ...

9 years, 9 months ago (2014-07-10 14:57:51 UTC) #3

jay.wren

nits: line 55 in tests/20... comment refers to JUJU_ENV_TYPE instead of JUJU_ENV i don't feel ...

9 years, 9 months ago (2014-07-10 17:24:34 UTC) #5

uros.jovanovic

9 years, 9 months ago (2014-07-10 19:33:58 UTC) #8

*** Submitted:

enables ftests on local env

Create local environment (with "local" also being the name of that environment)
and ftests can be now be run local as well.

R=rharding, jay.wren
CC=
https://codereview.appspot.com/113720043

Expand All Messages | Collapse All Messages