Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1514)

Issue 11370043: Removes charmStore from charm-panel

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by j.c.sackett
Modified:
10 years, 10 months ago
Reviewers:
bac, mp+175086, matthew.scott
Visibility:
Public.

Description

Removes charmStore from charm-panel Removes references to charmStore--and the implicit uses of the old charmworld API--from the charmpanel. https://code.launchpad.net/~jcsackett/juju-gui/rip-out-old-charmworld/+merge/175086 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes charmStore from charm-panel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +0 lines, -1 line 0 comments Download
M app/store/charm.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/charm-panel.js View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4
j.c.sackett
Please take a look.
10 years, 10 months ago (2013-07-16 17:26:14 UTC) #1
bac
LGTM, ty
10 years, 10 months ago (2013-07-16 17:36:29 UTC) #2
matthew.scott
LGTM
10 years, 10 months ago (2013-07-16 17:46:16 UTC) #3
j.c.sackett
10 years, 10 months ago (2013-07-16 18:45:27 UTC) #4
*** Submitted:

Removes charmStore from charm-panel

Removes references to charmStore--and the implicit uses of the old charmworld
API--from the charmpanel.

R=bac, matthew.scott
CC=
https://codereview.appspot.com/11370043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b