Issue 113700043: Log more errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113700043: Log more errors

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by haypo_gmail

Modified:
9 years, 8 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Log more errors

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -7 lines)			Patch
M	asyncio/base_events.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	asyncio/proactor_events.py	View	3 chunks	+13 lines, -3 lines	0 comments	Download
M	asyncio/unix_events.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	asyncio/windows_events.py	View	2 chunks	+13 lines, -3 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

yselivanov

Looks good and useful to me; there is one question re windows part though. https://codereview.appspot.com/113700043/diff/1/asyncio/windows_events.py ...

9 years, 8 months ago (2014-08-25 15:43:51 UTC) #1

haypo_gmail

9 years, 8 months ago (2014-08-25 15:58:33 UTC) #2

https://codereview.appspot.com/113700043/diff/1/asyncio/windows_events.py
File asyncio/windows_events.py (right):

https://codereview.appspot.com/113700043/diff/1/asyncio/windows_events.py#new...
asyncio/windows_events.py:124: self._loop.call_exception_handler(context)
On 2014/08/25 15:43:51, yselivanov wrote:
> Shouldn't you have a 'return' or 'raise' statement here?
> 
> Before your change the code execution would have stopped at this point, not
you
> call 'call_exception_handler()' and it continues.

If _overlapped.UnregisterWait() raises an exception, I don't think that you can
do anything useful. The best we can do is to log an error.

Clearing attributes is a deliberate choice. See
_OverlappedFuture._cancel_overlapped() which has the same implementation.

Expand All Messages | Collapse All Messages