Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6795)

Issue 113670043: Phase two of pruning snippets/new (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by PhilEHolmes
Modified:
9 years, 9 months ago
Reviewers:
email, marc
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Essentially this deletes almost all of the snippets/new files and replaces them with new, edited, or existing snippets from the LSR. Passes make doc on my local machine.

Patch Set 1 #

Patch Set 2 : Dummy to create tracker issue #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -3215 lines) Patch
M Documentation/de/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
D Documentation/snippets/correction-wanted.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download
D Documentation/snippets/entering-several-tuplets-using-only-one--times-command.ly View 1 chunk +0 lines, -36 lines 0 comments Download
A Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly View 1 chunk +34 lines, -0 lines 1 comment Download
M Documentation/snippets/expressive-headword.ly View 3 chunks +8 lines, -18 lines 0 comments Download
M Documentation/snippets/extending-glissandi-across-repeats.ly View 2 chunks +16 lines, -16 lines 0 comments Download
M Documentation/snippets/fretted-headword.ly View 2 chunks +13 lines, -24 lines 0 comments Download
M Documentation/snippets/generating-custom-flags.ly View 1 chunk +9 lines, -11 lines 0 comments Download
M Documentation/snippets/glissandi-can-skip-grobs.ly View 1 chunk +12 lines, -10 lines 0 comments Download
M Documentation/snippets/guitar-slides.ly View 1 chunk +11 lines, -12 lines 0 comments Download
M Documentation/snippets/hammer-on-and-pull-off.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/hammer-on-and-pull-off-using-chords.ly View 1 chunk +8 lines, -10 lines 0 comments Download
M Documentation/snippets/hammer-on-and-pull-off-using-voices.ly View 1 chunk +9 lines, -11 lines 0 comments Download
M Documentation/snippets/heavily-customized-polymetric-time-signatures.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly View 3 chunks +19 lines, -17 lines 0 comments Download
M Documentation/snippets/how-to-print-two-rehearsal-marks-above-and-below-the-same-barline-method-1.ly View 2 chunks +20 lines, -24 lines 0 comments Download
M Documentation/snippets/incipit.ly View 2 chunks +32 lines, -32 lines 0 comments Download
M Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/jazz-combo-template.ly View 2 chunks +8 lines, -10 lines 0 comments Download
M Documentation/snippets/keyboard-headword.ly View 1 chunk +7 lines, -8 lines 0 comments Download
M Documentation/snippets/making-glissandi-breakable.ly View 1 chunk +10 lines, -12 lines 0 comments Download
M Documentation/snippets/merging-multi-measure-rests-in-a-polyphonic-part.ly View 2 chunks +7 lines, -9 lines 0 comments Download
D Documentation/snippets/new/entering-several-tuplets-using-only-one--times-command.ly View 1 chunk +0 lines, -28 lines 0 comments Download
D Documentation/snippets/new/expressive-headword.ly View 1 chunk +0 lines, -268 lines 0 comments Download
D Documentation/snippets/new/extending-glissandi-across-repeats.ly View 1 chunk +0 lines, -62 lines 0 comments Download
D Documentation/snippets/new/fretted-headword.ly View 1 chunk +0 lines, -142 lines 0 comments Download
D Documentation/snippets/new/generating-custom-flags.ly View 1 chunk +0 lines, -62 lines 0 comments Download
D Documentation/snippets/new/glissandi-can-skip-grobs.ly View 1 chunk +0 lines, -13 lines 0 comments Download
D Documentation/snippets/new/guitar-slides.ly View 1 chunk +0 lines, -45 lines 0 comments Download
D Documentation/snippets/new/hammer-on-and-pull-off.ly View 1 chunk +0 lines, -18 lines 0 comments Download
D Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly View 1 chunk +0 lines, -21 lines 0 comments Download
D Documentation/snippets/new/hammer-on-and-pull-off-using-voices.ly View 1 chunk +0 lines, -20 lines 0 comments Download
D Documentation/snippets/new/heavily-customized-polymetric-time-signatures.ly View 1 chunk +0 lines, -35 lines 0 comments Download
D Documentation/snippets/new/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly View 1 chunk +0 lines, -168 lines 0 comments Download
D Documentation/snippets/new/how-to-print-two-rehearsal-marks-above-and-below-the-same-barline-method-1.ly View 1 chunk +0 lines, -47 lines 0 comments Download
D Documentation/snippets/new/incipit.ly View 1 chunk +0 lines, -267 lines 0 comments Download
D Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly View 1 chunk +0 lines, -39 lines 0 comments Download
D Documentation/snippets/new/jazz-combo-template.ly View 1 chunk +0 lines, -272 lines 0 comments Download
D Documentation/snippets/new/keyboard-headword.ly View 1 chunk +0 lines, -242 lines 0 comments Download
D Documentation/snippets/new/making-glissandi-breakable.ly View 1 chunk +0 lines, -31 lines 0 comments Download
D Documentation/snippets/new/merging-multi-measure-rests-in-a-polyphonic-part.ly View 1 chunk +0 lines, -35 lines 0 comments Download
D Documentation/snippets/new/numbering-groups-of-measures.ly View 1 chunk +0 lines, -53 lines 0 comments Download
D Documentation/snippets/new/numbers-as-easy-note-heads.ly View 1 chunk +0 lines, -54 lines 0 comments Download
D Documentation/snippets/new/pitches-headword.ly View 1 chunk +0 lines, -137 lines 0 comments Download
D Documentation/snippets/new/positioning-multi-measure-rests.ly View 1 chunk +0 lines, -59 lines 0 comments Download
D Documentation/snippets/new/printing-hairpins-in-various-styles.ly View 1 chunk +0 lines, -30 lines 0 comments Download
D Documentation/snippets/new/quoting-another-voice-with-transposition.ly View 1 chunk +0 lines, -42 lines 0 comments Download
D Documentation/snippets/new/redefining-grace-note-global-defaults.ly View 1 chunk +0 lines, -33 lines 0 comments Download
D Documentation/snippets/new/score-for-diatonic-accordion.ly View 1 chunk +0 lines, -240 lines 0 comments Download
D Documentation/snippets/new/strict-beat-beaming.ly View 1 chunk +0 lines, -21 lines 0 comments Download
D Documentation/snippets/new/string-number-extender-lines.ly View 1 chunk +0 lines, -34 lines 0 comments Download
D Documentation/snippets/new/using-a-tick-as-the-breath-mark-symbol.ly View 1 chunk +0 lines, -25 lines 0 comments Download
D Documentation/snippets/new/using-alternative-flag-styles.ly View 1 chunk +0 lines, -33 lines 0 comments Download
D Documentation/snippets/new/using-an-extra-voice-for-breaks.ly View 1 chunk +0 lines, -41 lines 0 comments Download
D Documentation/snippets/new/using-grace-note-slashes-with-normal-heads.ly View 1 chunk +0 lines, -18 lines 0 comments Download
D Documentation/snippets/new/vertically-aligned-dynamics-and-textscripts.ly View 1 chunk +0 lines, -34 lines 0 comments Download
D Documentation/snippets/new/woodwind-diagrams-key-lists.ly View 1 chunk +0 lines, -30 lines 0 comments Download
M Documentation/snippets/numbering-groups-of-measures.ly View 1 chunk +22 lines, -18 lines 0 comments Download
M Documentation/snippets/numbers-as-easy-note-heads.ly View 1 chunk +15 lines, -15 lines 0 comments Download
M Documentation/snippets/pitches-headword.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/positioning-multi-measure-rests.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/printing-hairpins-in-various-styles.ly View 1 chunk +8 lines, -10 lines 0 comments Download
M Documentation/snippets/quoting-another-voice-with-transposition.ly View 2 chunks +10 lines, -11 lines 0 comments Download
M Documentation/snippets/redefining-grace-note-global-defaults.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/rhythms.snippet-list View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/score-for-diatonic-accordion.ly View 4 chunks +8 lines, -18 lines 0 comments Download
M Documentation/snippets/strict-beat-beaming.ly View 1 chunk +12 lines, -15 lines 0 comments Download
M Documentation/snippets/string-number-extender-lines.ly View 2 chunks +15 lines, -17 lines 0 comments Download
M Documentation/snippets/syntax-and-expressions.snippet-list View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/using-a-tick-as-the-breath-mark-symbol.ly View 1 chunk +13 lines, -13 lines 0 comments Download
M Documentation/snippets/using-alternative-flag-styles.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/using-an-extra-voice-for-breaks.ly View 1 chunk +24 lines, -30 lines 0 comments Download
M Documentation/snippets/using-grace-note-slashes-with-normal-heads.ly View 2 chunks +7 lines, -9 lines 0 comments Download
M Documentation/snippets/vertically-aligned-dynamics-and-textscripts.ly View 3 chunks +9 lines, -13 lines 0 comments Download
M Documentation/snippets/woodwind-diagrams-key-lists.ly View 2 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 5
PhilEHolmes
Dummy to create tracker issue
9 years, 9 months ago (2014-07-30 10:15:43 UTC) #1
PhilEHolmes
Please review.
9 years, 9 months ago (2014-07-30 10:17:54 UTC) #2
marc
https://codereview.appspot.com/113670043/diff/20001/Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly File Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly (right): https://codereview.appspot.com/113670043/diff/20001/Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly#newcode16 Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly:16: @code{\\times} expression, thus saving typing. s/times/tuplet/2
9 years, 9 months ago (2014-07-30 14:57:30 UTC) #3
email_philholmes.net
----- Original Message ----- From: <marc@hohlart.de> To: <PhilEHolmes@googlemail.com> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Wednesday, July 30, ...
9 years, 9 months ago (2014-07-30 15:34:48 UTC) #4
marc
9 years, 9 months ago (2014-07-31 06:47:05 UTC) #5
Am 30.07.2014 um 17:34 schrieb Phil Holmes:
> ----- Original Message ----- From: <marc@hohlart.de>
> To: <PhilEHolmes@googlemail.com>
> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
> Sent: Wednesday, July 30, 2014 3:57 PM
> Subject: Re: Phase two of pruning snippets/new (issue 113670043 by
> PhilEHolmes@googlemail.com)
>
>
>>
>>
https://codereview.appspot.com/113670043/diff/20001/Documentation/snippets/en...
>>
>> File
>>
Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly
>>
>> (right):
>>
>>
https://codereview.appspot.com/113670043/diff/20001/Documentation/snippets/en...
>>
>>
Documentation/snippets/entering-several-tuplets-using-only-one--tuplet-command.ly:16:
>>
>> @code{\\times} expression, thus saving typing.
>> s/times/tuplet/2
>>
>> https://codereview.appspot.com/113670043/
>
> That snippet may be the death of me.

;-)

>  I've changed it in the LSR - I'd
> prefer to run with this patch and correct that error next import.

That's ok for me. Otherwise LGTM.

Marc
>
> --
> Phil Holmes
>

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b