Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2453)

Issue 11357045: Allow for \n in description and changelog entries

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by rharding
Modified:
10 years, 10 months ago
Reviewers:
mp+175084
Visibility:
Public.

Description

Allow for \n in description and changelog entries - Add a respect-whitespace css class that we wrap around that content. Careful using this as it makes the element very sensitive to any whitespace in the template and makes it less readable, ugh. https://code.launchpad.net/~rharding/juju-gui/respect-newlines/+merge/175084 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Allow for \n in description and changelog entries #

Patch Set 3 : Allow for \n in description and changelog entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 3 chunks +4 lines, -10 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rharding
Please take a look.
10 years, 10 months ago (2013-07-16 17:19:41 UTC) #1
rharding
Please take a look.
10 years, 10 months ago (2013-07-16 17:35:30 UTC) #2
rharding
LGTM self-reviewing.
10 years, 10 months ago (2013-07-16 17:52:14 UTC) #3
rharding
Gary has peeked at and we'll use this is a small step towards the bugs ...
10 years, 10 months ago (2013-07-16 17:53:45 UTC) #4
rharding
10 years, 10 months ago (2013-07-16 17:59:54 UTC) #5
*** Submitted:

Allow for \n in description and changelog entries

- Add a respect-whitespace css class that we wrap around that content.

Careful using this as it makes the element very sensitive to any whitespace in
the template and makes it less readable, ugh.

R=
CC=
https://codereview.appspot.com/11357045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b