Issue 11355044: code review 11355044: syscall: record argument size for all assembly functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11355044: code review 11355044: syscall: record argument size for all assembly functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rsc

Modified:
11 years, 11 months ago

Reviewers:
dvyukov

CC:
golang-dev, dvyukov

Visibility:
Public.

Description

syscall: record argument size for all assembly functions While we're here, fix Syscall9 on NetBSD and OpenBSD: it was storing the results into the wrong memory locations. I guess no one uses that function's results on those systems. Part of cleaning up stack traces and argument frame information.

Patch Set 1 #

Patch Set 2 : diff -r 8b12d6f12155 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8b12d6f12155 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e8e42473a635 https://code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -91 lines)			Patch
M	src/pkg/syscall/asm_darwin_386.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_darwin_amd64.s	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/asm_freebsd_386.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_freebsd_amd64.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_freebsd_arm.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_386.s	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_amd64.s	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_arm.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_netbsd_386.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_netbsd_amd64.s	View	1	5 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pkg/syscall/asm_netbsd_arm.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_openbsd_386.s	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_openbsd_amd64.s	View	1	5 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pkg/syscall/asm_plan9_386.s	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/asm_plan9_amd64.s	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 11 months ago (2013-07-16 16:17:38 UTC) #1

rsc

11 years, 11 months ago (2013-07-16 20:23:57 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=d57d242b9ced ***

syscall: record argument size for all assembly functions

While we're here, fix Syscall9 on NetBSD and OpenBSD:
it was storing the results into the wrong memory locations.
I guess no one uses that function's results on those systems.

Part of cleaning up stack traces and argument frame information.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/11355044

Expand All Messages | Collapse All Messages