Issue 11355043: Update charms to display total commit counts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11355043: Update charms to display total commit counts.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
bac, mp+175041, j.c.sackett, gary.poster

Visibility:
Public.

Description

Update charms to display total commit counts. - Fixes #1201601 to make the revno as the commit count to show total commits in the history and better match the downloads. - Fixes #1201602 to move the QA tab to the end of the tab list for better UX. https://code.launchpad.net/~rharding/juju-gui/total-commits-1201601/+merge/175041 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update charms to display total commit counts. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/charm.js	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/widgets/charm-token.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/test_charm_token.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/test_charm_token_drag_and_drop.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_model.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rharding

10 years, 10 months ago (2013-07-16 15:22:06 UTC) #5

*** Submitted:

Update charms to display total commit counts.

- Fixes #1201601 to make the revno as the commit count to show total commits
in the history and better match the downloads.
- Fixes #1201602 to move the QA tab to the end of the tab list for better UX.

R=j.c.sackett, bac
CC=
https://codereview.appspot.com/11355043

Expand All Messages | Collapse All Messages