Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1039)

Issue 11352043: Visual update from feedback

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by rharding
Modified:
10 years, 10 months ago
Reviewers:
mp+175034, gary.poster
Visibility:
Public.

Description

Visual update from feedback Makes changes as requested by Jamie. His notes included here: Global header: The logout button needs to be 14px light All buttons should have 3px radius (not 4px as currently) Charm details: The details pages (summary, Readme, etc.) need more left and right padding. It's 80px left and 70px right. The tab nav should align the content below it (so start at 80px) Need to introduce sub-heading type styling (as per the prototype) The paragraphs need 30px margin on the bottom so they look closer to their headings. The headings should have 20px margin bottom. The "Add to my Canvas" button should be 40px (it's 41px) The grabber should be 40px (it's 38px) and line up with the "Add to my canvas" button. The paragraph leading should be 20px https://code.launchpad.net/~juju-gui/juju-gui/visual-update-6/+merge/175034 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Visual update from feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -69 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/browser/browser-icon.less View 1 chunk +3 lines, -4 lines 0 comments Download
M lib/views/browser/charm-full.less View 9 chunks +34 lines, -35 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +1 line, -7 lines 0 comments Download
D lib/views/browser/mixins.less View 1 chunk +0 lines, -8 lines 0 comments Download
M lib/views/browser/vars.less View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/juju-inspector.less View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/views/stylesheet.less View 12 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 10 months ago (2013-07-16 14:34:34 UTC) #1
rharding
LGTM - updated branch from huw's work in https://codereview.appspot.com/11332043/
10 years, 10 months ago (2013-07-16 14:35:52 UTC) #2
gary.poster
LGTM. Thanks to Huw and you, both.
10 years, 10 months ago (2013-07-16 15:00:26 UTC) #3
rharding
10 years, 10 months ago (2013-07-16 15:14:26 UTC) #4
*** Submitted:

Visual update from feedback

Makes changes as requested by Jamie. His notes included here:

Global header:
The logout button needs to be 14px light
All buttons should have 3px radius (not 4px as currently)

Charm details:
The details pages (summary, Readme, etc.) need more left and right
padding. It's 80px left and 70px right.
The tab nav should align the content below it (so start at 80px)
Need to introduce sub-heading type styling (as per the prototype)
The paragraphs need 30px margin on the bottom so they look closer to their
headings. The headings should have 20px margin bottom.
The "Add to my Canvas" button should be 40px (it's 41px)
The grabber should be 40px (it's 38px) and line up with the "Add to my canvas"
button.
The paragraph leading should be 20px

R=gary.poster
CC=
https://codereview.appspot.com/11352043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b