Issue 11351046: Fixed inspector unit list sorting bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11351046: Fixed inspector unit list sorting bug

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
mp+176715, gary.poster, matthew.scott

Visibility:
Public.

Description

Fixed inspector unit list sorting bug In order to fix the sorting bug with our current D3 version we need to render all unit lists at once and then hide/show when units are in those lists. This also includes a driveby fix for https image and having the unit lists closed by default https://code.launchpad.net/~hatch/juju-gui/sort-unit-headers/+merge/176715 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed inspector unit list sorting bug #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -27 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/inspector.js	View	3 chunks	+19 lines, -4 lines	0 comments	Download
M	lib/views/cookies.less	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/test_inspector_overview.js	View	3 chunks	+40 lines, -21 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

LGTM other than undefined/0 concern: please address or explain that. https://codereview.appspot.com/11351046/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/11351046/diff/1/app/views/inspector.js#newcode988 ...

10 years, 9 months ago (2013-07-24 17:35:05 UTC) #3

jeff.pihach

Thanks for the reviews - response below. https://codereview.appspot.com/11351046/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/11351046/diff/1/app/views/inspector.js#newcode988 app/views/inspector.js:988: return d.units.length ...

10 years, 9 months ago (2013-07-24 18:33:26 UTC) #4

jeff.pihach

10 years, 9 months ago (2013-07-24 19:01:06 UTC) #5

*** Submitted:

Fixed inspector unit list sorting bug

In order to fix the sorting bug with our current D3 version
we need to render all unit lists at once and then hide/show
when units are in those lists.

This also includes a driveby fix for https image and having
the unit lists closed by default

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/11351046

Expand All Messages | Collapse All Messages