https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (left): https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#oldcode609 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:609: public void TestChunkUpload_ServerUnavailable_KnownSize() Add comment. This test covered the ...
11 years, 4 months ago
(2013-07-22 01:02:58 UTC)
#1
Hi Gus, Like I promised attached is a fix to resumable media upload. I fixed ...
11 years, 4 months ago
(2013-07-23 22:05:10 UTC)
#3
Hi Gus,
Like I promised attached is a fix to resumable media upload.
I fixed it in the Java client library and I was pretty sure that we are going to
have a similar bug in the .NET client library.
So I added more tests, and I'm happy with current implementation.
Thanks,
Eyal
On 2013/07/23 22:05:10, peleyal wrote: > Hi Gus, > Like I promised attached is a ...
11 years, 4 months ago
(2013-08-02 21:39:01 UTC)
#4
On 2013/07/23 22:05:10, peleyal wrote:
> Hi Gus,
> Like I promised attached is a fix to resumable media upload.
> I fixed it in the Java client library and I was pretty sure that we are going
to
> have a similar bug in the .NET client library.
>
> So I added more tests, and I'm happy with current implementation.
>
> Thanks,
> Eyal
Ping ... :)
A few documentation comments and a design consideration https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode52 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:52: public ...
11 years, 4 months ago
(2013-08-02 22:01:19 UTC)
#5
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode52 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:52: public void SetUp() On 2013/08/02 22:01:20, class wrote: > ...
11 years, 4 months ago
(2013-08-05 15:15:29 UTC)
#6
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/...
File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right):
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:52: public void SetUp()
On 2013/08/02 22:01:20, class wrote:
> Consider passing a boolean instead of commenting out
Done.
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:308: /// Gets or sets
the amount of bytes the server reads when error occurred. The default value is
<c>0</c>,
On 2013/08/02 22:01:20, class wrote:
> Gets or sets the *number* of bytes
Done.
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:654: /// An helper test
which tests that the client accepts 308 and 503 responses when uploading chunks.
This test
On 2013/08/02 22:01:20, class wrote:
> This should be "A helper test that tests..."
Done.
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:1039: // less that the
minimum
On 2013/08/02 22:01:20, class wrote:
> Less than the minimum?
Done.
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis/Apis/[Media...
File Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs (right):
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis/Apis/[Media...
Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs:178: /// Gets or sets the
size of each chunk sent to the server.
I prefer the 'gets or sets' just because it's the way the framework classes were
documented.
On 2013/08/02 22:01:20, class wrote:
> I don't have too strong of an opinion on this but I think it would be
acceptable
> to remove the language pattern:
>
> "Gets or sets the ..."
>
> We could alternatively use something like:
> "The size of each chunk sent to the server."
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis/Apis/[Media...
Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs:510: // if the number of
bytes received by the sever isn't equal to the amount of bytes the client sent,
it
On 2013/08/02 22:01:20, class wrote:
> A revision:
>
> // if the number of bytes received by the server isn't equal to the amount of
> bytes the client sent,
> // resend bytes and copy to the current request's stream from the last
request
>
> server was misspelled and the last part of the comment was made a little more
> concise
Done.
There is still one typo I missed the first time, LGTM after renaming. https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File ...
11 years, 3 months ago
(2013-08-08 17:32:31 UTC)
#7
My bad. Waiting for your approval. Thanks, Eyal https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode424 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:424: if ...
11 years, 3 months ago
(2013-08-08 20:45:01 UTC)
#8
Issue 11347044: Issue 360: Fix a bug in ResumableUpload when media size is unknown
(Closed)
Created 11 years, 4 months ago by peleyal
Modified 11 years, 3 months ago
Reviewers: class
Base URL: https://google-api-dotnet-client.googlecode.com/hg/
Comments: 39