Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(597)

Issue 11347044: Issue 360: Fix a bug in ResumableUpload when media size is unknown (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by peleyal
Modified:
5 years, 11 months ago
Reviewers:
class
CC:
apiary-dotnet-client_google.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Fix a bug in ResumableUpload when media size is unknown

Patch Set 1 #

Patch Set 2 : Fix the bug #

Total comments: 21

Patch Set 3 : There is nothing better than self review :) #

Patch Set 4 : minor #

Patch Set 5 : minor #

Patch Set 6 : minor #

Patch Set 7 : minor #

Total comments: 14

Patch Set 8 : Class review #

Total comments: 4

Patch Set 9 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -110 lines) Patch
M Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs View 1 2 chunks +1 line, -2 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs View 1 2 3 4 5 6 7 8 26 chunks +170 lines, -47 lines 0 comments Download
M Src/GoogleApis.Tests/GoogleApis.Tests.csproj View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Src/GoogleApis/Apis/Services/BaseClientService.cs View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs View 1 2 3 4 5 6 7 14 chunks +68 lines, -53 lines 0 comments Download

Messages

Total messages: 9
peleyal
https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (left): https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#oldcode609 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:609: public void TestChunkUpload_ServerUnavailable_KnownSize() Add comment. This test covered the ...
6 years ago (2013-07-22 01:02:58 UTC) #1
peleyal
https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (left): https://codereview.appspot.com/11347044/diff/3001/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#oldcode609 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:609: public void TestChunkUpload_ServerUnavailable_KnownSize() On 2013/07/22 01:02:58, peleyal wrote: > ...
5 years, 12 months ago (2013-07-23 21:48:11 UTC) #2
peleyal
Hi Gus, Like I promised attached is a fix to resumable media upload. I fixed ...
5 years, 12 months ago (2013-07-23 22:05:10 UTC) #3
peleyal
On 2013/07/23 22:05:10, peleyal wrote: > Hi Gus, > Like I promised attached is a ...
5 years, 11 months ago (2013-08-02 21:39:01 UTC) #4
class
A few documentation comments and a design consideration https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode52 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:52: public ...
5 years, 11 months ago (2013-08-02 22:01:19 UTC) #5
peleyal
https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode52 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:52: public void SetUp() On 2013/08/02 22:01:20, class wrote: > ...
5 years, 11 months ago (2013-08-05 15:15:29 UTC) #6
class
There is still one typo I missed the first time, LGTM after renaming. https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File ...
5 years, 11 months ago (2013-08-08 17:32:31 UTC) #7
peleyal
My bad. Waiting for your approval. Thanks, Eyal https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs File Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs (right): https://codereview.appspot.com/11347044/diff/20006/Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs#newcode424 Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs:424: if ...
5 years, 11 months ago (2013-08-08 20:45:01 UTC) #8
class
5 years, 11 months ago (2013-08-08 21:44:28 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b