Issue 11347043: code review 11347043: go.tools/ssa: fixes required by go/types CL 11317043: t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11347043: code review 11347043: go.tools/ssa: fixes required by go/types CL 11317043: t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by adonovan

Modified:
12 years, 1 month ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

go.tools/ssa: fixes required by go/types CL 11317043: the last parameter of a variadic signature is now a slice type.

Patch Set 2 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Patch Set 7 : diff -r 9f7367db9db0 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 8 : diff -r 4af97aa2c622 https://code.google.com/p/go.tools #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -14 lines)			Patch
	M	importer/pkginfo.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	ssa/builder.go	View	1 2	2 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 1 month ago (2013-07-16 13:57:20 UTC) #1

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 1 month ago (2013-07-16 13:58:05 UTC) #2

gri

LGTM https://codereview.appspot.com/11347043/diff/17004/go/types/types.go File go/types/types.go (right): https://codereview.appspot.com/11347043/diff/17004/go/types/types.go#newcode202 go/types/types.go:202: if isVariadic { this is not needed anymore ...

12 years, 1 month ago (2013-07-16 16:14:46 UTC) #3

adonovan

12 years, 1 month ago (2013-07-16 16:22:24 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=1b427651f7f2&repo=tools ***

go.tools/ssa: fixes required by go/types CL 11317043: the last
parameter of a variadic signature is now a slice type.

R=gri
CC=golang-dev
https://codereview.appspot.com/11347043

Expand All Messages | Collapse All Messages