Issue 113350043: code review 113350043: cmd/gc: do not mark PC as pointer on stack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113350043: code review 113350043: cmd/gc: do not mark PC as pointer on stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by dvyukov

Modified:
9 years, 9 months ago

Reviewers:
0intro

CC:
golang-codereviews, 0intro, aram

Visibility:
Public.

Description

cmd/gc: do not mark PC as pointer on stack GC thinks that it's an invalid pointer on plan9: http://build.golang.org/log/f7da638a20544ef7f45e81f23fdbc4875044c296

Patch Set 1 #

Patch Set 2 : diff -r e1d0077340e8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e1d0077340e8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e1d0077340e8 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/gc/select.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com (cc: 0intro@gmail.com, aram@mgk.ro), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

9 years, 9 months ago (2014-07-20 14:31:03 UTC) #1

dvyukov

9 years, 9 months ago (2014-07-20 14:52:53 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d5c083552430 ***

cmd/gc: do not mark PC as pointer on stack
GC thinks that it's an invalid pointer on plan9:
http://build.golang.org/log/f7da638a20544ef7f45e81f23fdbc4875044c296

LGTM=0intro
R=golang-codereviews, 0intro
CC=aram, golang-codereviews
https://codereview.appspot.com/113350043

Expand All Messages | Collapse All Messages