Issue 113300044: code review 113300044: cmd/api: ignore internal packages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113300044: code review 113300044: cmd/api: ignore internal packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by bradfitz

Modified:
10 years, 10 months ago

Reviewers:
gobot, rsc, dave

CC:
rsc, dave_cheney.net, golang-codereviews

Visibility:
Public.

cmd/api: ignore internal packages We might want to add a go/build.IsInternal(pkg string) bool later, but this works for now.

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	src/cmd/api/goapi.go	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	src/cmd/api/goapi_test.go	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 6

bradfitz

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 10 months ago (2014-07-21 03:44:17 UTC) #1

rsc

The regexp is wrong. Look for (^|/)internal($|/). As written it will match foo-internal-bar and so ...

10 years, 10 months ago (2014-07-21 18:49:11 UTC) #3

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=e00870c21166 *** cmd/api: ignore internal packages We might want to add a ...

10 years, 10 months ago (2014-07-21 19:06:33 UTC) #5

gobot

10 years, 10 months ago (2014-07-21 20:56:42 UTC) #6

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/7229903f9ee351a5ec2b167f40fcd71533a6ef5a